[Procedures] Fix Identityand ConnectionId Regression#5323
Merged
Conversation
joshua-spacetime
left a comment
joshua-spacetime
left a comment
Contributor
There was a problem hiding this comment.
One small request, but otherwise LGTM.
joshua-spacetime
approved these changes
Jun 16, 2026
Collaborator
|
this had merge conflicts in the queue |
Signed-off-by: Zeke Foppa <196249+bfops@users.noreply.github.com>
Merged
via the queue into
clockworklabs:master
with commit Jun 17, 2026
3ec168d
78 of 89 checks passed
Closed
rekhoff
pushed a commit
that referenced
this pull request
Jun 29, 2026
Closes #5250 the sender and connection_id from the caller while now it is always empty (which is wrong) Correct it. Also fully migrate to `database_identity` which was forgotten about so i deprecated it for procedures (since they are now stable) and just changed it for HttpHandlers (because they are still unstable) @gefjon since you did the lil woopsie (ugh pinging you again lol hope im not annoying haha) Breaking the HttpHandler function which is unstable. Restoring behaviour of 2.3 which got lost with 2.4. <!-- If this is an API or ABI breaking change, please apply the corresponding GitHub label. --> 1. Trivial refactoring <!-- How complicated do you think these changes are? Grade on a scale from 1 to 5, where 1 is a trivial change, and 5 is a deep-reaching and complex change. This complexity rating applies not only to the complexity apparent in the diff, but also to its interactions with existing and future code. If you answered more than a 2, explain what is complex about the PR, and what other components it interacts with in potentially concerning ways. --> <!-- Describe any testing you've done, and any testing you'd like your reviewers to do, so that you're confident that all the changes work as expected! --> - [x] The caller identity is there again for Procedures. --------- Signed-off-by: Zeke Foppa <196249+bfops@users.noreply.github.com> Co-authored-by: joshua-spacetime <josh@clockworklabs.io> Co-authored-by: Zeke Foppa <196249+bfops@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Closes #5250
#4636 introduced a regression where the ProcedureContext used to include the sender and connection_id from the caller while now it is always empty (which is wrong)
Correct it.
Also fully migrate to
database_identitywhich was forgotten about so i deprecated it for procedures (since they are now stable) and just changed it for HttpHandlers (because they are still unstable)@gefjon since you did the lil woopsie (ugh pinging you again lol hope im not annoying haha)
API and ABI breaking changes
Breaking the HttpHandler function which is unstable.
Restoring behaviour of 2.3 which got lost with 2.4.
Expected complexity level and risk
Testing