Use SpacetimeDBGuard for SDK test suite#5340
Merged
Merged
Conversation
joshua-spacetime
requested review from
bfops,
cloutiertyler and
jdetter
as code owners
joshua-spacetime
force-pushed
the
joshua/server-process-per-sdk-test
branch
3 times, most recently
from
1a6f632 to
5bf6d8f
Compare
joshua-spacetime
changed the base branch from
master
to
joshua/fix/sats-proptest-oom
joshua-spacetime
force-pushed
the
joshua/server-process-per-sdk-test
branch
from
3ead61d to
1ed6ee1
Compare
bfops
reviewed
Jun 16, 2026
bfops
reviewed
Jun 16, 2026
bfops
reviewed
Jun 16, 2026
bfops
reviewed
Jun 16, 2026
bfops
approved these changes
Jun 16, 2026
bfops
left a comment
bfops
left a comment
Collaborator
There was a problem hiding this comment.
The diff itself LGTM. I haven't thought deeply about all these different test harnesses and how I would expect this plumbing to look in a vacuum (or if something's missing), but what's there seems reasonable. It's test-only changes, so if it passes CI I think this LGTM.
joshua-spacetime
force-pushed
the
joshua/server-process-per-sdk-test
branch
from
1ed6ee1 to
0c62b5b
Compare
joshua-spacetime
removed this pull request from the merge queue due to a manual request
joshua-spacetime
removed this pull request from the merge queue due to a manual request
joshua-spacetime
removed this pull request from the merge queue due to a manual request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Use an isolated server process per SDK test instead of a single process for all of the tests. In addition to reducing the memory footprint of each test run, this should also allow for more parallelism among the individual tests.
API and ABI breaking changes
None
Expected complexity level and risk
1.5
Testing
The SDK test suite should continue to work