Drop tps threshold in keynote bench#5360
Merged
Merged
Conversation
jdetter
approved these changes
Jun 17, 2026
joshua-spacetime
removed this pull request from the merge queue due to a manual request
Closed
4 tasks
This was referenced Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Reviewing recent benchmark runs, it appears that #5071 probably regressed TPS by around 3-5%. I don't want to revert that change because it has implications for replication, and so for now we'll just live with the slight regression.
API and ABI breaking changes
None
Expected complexity level and risk
0
Testing
N/A