Remove LLM-benchmark timeout#5458
Merged
Merged
Conversation
JulienLavocat
requested review from
bfops,
cloutiertyler and
jdetter
as code owners
JulienLavocat
force-pushed
the
julien/llm-benchmark-timeout
branch
from
55b00b5 to
116e0d7
Compare
bfops
reviewed
Jun 29, 2026
JulienLavocat
force-pushed
the
julien/llm-benchmark-timeout
branch
from
23ca089 to
d31049b
Compare
Co-authored-by: Zeke Foppa <196249+bfops@users.noreply.github.com> Signed-off-by: Julien Lavocat <JulienLavocat@users.noreply.github.com>
JulienLavocat
force-pushed
the
julien/llm-benchmark-timeout
branch
from
d31049b to
0c80a4a
Compare
jdetter
approved these changes
Jun 30, 2026
Contributor
|
Just a heads up this seems to just remove the timeout completely |
JulienLavocat
changed the title
Contributor
Author
|
I've updated the description and title @jdetter |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Periodic LLM benchmark jobs can take more than 3 hour, this PR remove the 3 hour limit in favor of Github's default to 6 hours
API and ABI breaking changes
None
Expected complexity level and risk
1
Testing
Not tested, I need to merge to be able to test as it is a CI change