Fix the debugger's O (force step-out) key

Pressing `O` in a debug session sent a `:force-out` command, but the
middleware has no such command: force-out is `:out` sent with a `force?`
flag. The unknown command aborted the session and raised an error.

Map the `O` key to the `out` command so the uppercase-key force handling
in `cider-debug-mode-send-reply' produces a proper forced `:out`, which
matches what the menu and `cider-debug-force-out` already send.

Author: bbatsov

CHANGELOG.md

@@ -45,6 +45,7 @@
 
 ### Bugs fixed
 
+- Fix the debugger's `O` (force step-out) key, which aborted the session with an error because it sent an invalid `:force-out` command instead of a forced `:out`.
 - Fix the debugger's menu-bar menu: it advertised the wrong key for "Inject value" (`i` instead of `j`) and was missing entries for stepping in, showing the stacktrace, and tracing.
 - Fix `cider-log-kill-appender`'s confirmation message, which had the appender and framework names swapped.
 - [#4066](https://github.com/clojure-emacs/cider/pull/4066): Jump to the actual source when clicking a stack frame for a top-level anonymous function (the `deftest` shape), instead of landing in `clojure.core/fn` ([#3157](https://github.com/clojure-emacs/cider/issues/3157)).

lisp/cider-debug.el

@@ -186,7 +186,10 @@ Can be toggled at any time with `\\[cider-debug-toggle-locals]'."
     (?n "next" "next")
     (?i "in" "in")
     (?o "out" "out")
-    (?O "force-out" nil)
+    ;; Force-out is not a distinct middleware command: it's `out' sent with a
+    ;; `force?' flag, which `cider-debug-mode-send-reply' adds because the key
+    ;; is uppercase.
+    (?O "out" nil)
     (?h "here" "here")
     (?e "eval" "eval")
     (?p "inspect" "inspect")

test/cider-debug-tests.el

@@ -260,7 +260,19 @@
 
   (it "send a forced :out for `cider-debug-force-out'"
     (cider-debug-force-out)
-    (expect 'cider-debug-mode-send-reply :to-have-been-called-with ":out" nil t))
+    (expect 'cider-debug-mode-send-reply :to-have-been-called-with ":out" nil t)))
+
+(describe "cider-debug-mode-send-reply"
+  (it "sends a forced :out for the uppercase O key, not an invalid :force-out"
+    ;; The middleware has no `:force-out' command; force-out is `:out' with a
+    ;; `force?' flag, keyed off the uppercase letter.
+    (spy-on 'cider-nrepl-send-unhandled-request)
+    (let ((last-command-event ?O)
+          (cider--debug-mode-response (nrepl-dict "key" "the-key")))
+      (call-interactively 'cider-debug-mode-send-reply)
+      (let ((request (car (spy-calls-args-for 'cider-nrepl-send-unhandled-request 0))))
+        (expect (cadr (member "input" request)) :to-equal "{:response :out :force? true}")
+        (expect (cadr (member "key" request)) :to-equal "the-key"))))
 
   (it "expose every catalog command as a callable command"
     ;; Every entry in `cider--debug-commands' feeds the menus, so its