2.0 polish: theme-aware gensym faces, checkdoc zero, friendlier defaults, refcard update#4068
Merged
Conversation
cider-macrostep-gensym-colors hardcoded seven hex colors (the last hardcoded color list in the codebase); replace it with cider-macrostep-gensym-faces, a palette inheriting from standard font-lock faces. The option was unreleased, so no aliases needed.
Fix the six genuine warnings (missing arguments in docstrings, an unquoted symbol, an unescaped paren, an embedded keycode) and disable checkdoc's experimental third-person-verb check in the Eldev config - it misfires on nouns like "tests" and "highlights", which a Clojure IDE can hardly avoid in docstrings.
History is cheap, and 500 entries is easy to blow through in a day of REPL work. Also freshen cider-print-buffer-size's docstring, which still described the pre-#4049 per-chunk font-locking behavior; its 4K default stays - benchmarking chunk sizes against a live nREPL showed no measurable difference between 4K and 16K, and a regression at 64K.
Truncate huge eval results before the overlay face bookkeeping walks them (they get cut to the display threshold anyway), and give the reload-clear sync request a 60s timeout - the op is fast by itself but serializes behind any refresh already in flight (#3652).
cider-macroexpand-all moved to C-c M-m a, and the card now also lists inline macrostep, source-based find-references, the who-calls / who-implements queries and cider-ns-reload.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another small pre-2.0 batch, one commit per item:
cider-macrostep-gensym-faces: the gensym palette is now theme-aware faces instead of hardcoded hex colors (the option was unreleased, so renamed outright).cider-repl-history-size500 -> 5000. (Acider-print-buffer-sizebump was considered but benchmarking against a live nREPL showed no measurable difference between 4K and 16K on multi-MB results, and a regression at 64K, so the 4K default stays.)reload-cleara 60s timeout since it serializes behind in-flight refreshes (refresh ops shouldn't have a timeout #3652).C-c M-m amove, inline macrostep, source-based find-references, who-calls/who-implements,cider-ns-reload.