* goog.object/containsKey type inference doesn't work for reason, leave a trail for later

Author: swannodette

src/main/cljs/cljs/core.cljs

@@ -12178,6 +12178,8 @@ reduces them without incurring seq initialization"
   Object
   (findInternedVar [this sym]
     (let [k (munge (str_ sym))]
+      ;; FIXME: this shouldn't need ^boolean due to GCL library analysis,
+      ;; but not currently working
       (when ^boolean (gobject/containsKey obj k)
         (let [var-sym (symbol (str_ name) (str_ sym))
               var-meta {:ns this}]

src/test/clojure/cljs/externs_parsing_tests.clj

@@ -37,6 +37,12 @@
     (is (= 'any (get-in ns [:defs 'get :ret-tag])))
     (is (= 'array (get-in ns [:defs 'getKeys :ret-tag])))))
 
+(comment
+  ;; works
+  (get-in (externs/analyze-goog-file "goog/object/object.js")
+    [:defs 'containsKey :ret-tag])
+  )
+
 (deftest test-parse-super
   (let [info (->
                (filter

src/test/clojure/cljs/type_inference_tests.clj

@@ -394,3 +394,15 @@
                    (:import [goog.history Html5History]))
                  (Html5History.)]
                {} true))))))
+
+;; FIXME: infers any instead of boolean, nothing wrong w/ the externs parsing
+;; but this definitely does not work at the moment
+#_(deftest test-goog-infer
+  (is (= 'boolean
+        (:tag
+          (env/with-compiler-env (env/default-compiler-env)
+            (ana/analyze-form-seq
+              '[(ns test.foo
+                  (:require [goog.object :as gobject]))
+                (gobject/containsKey (js-object) "foo")]
+              {} true))))))