CLJS-1432 '$ and '. symbols collision under advanced

Author: tonsky

src/main/clojure/cljs/analyzer.cljc

@@ -378,7 +378,9 @@
         name   (if (keyword? value)
                  (subs (str value) 1)
                  (str value))
-        name   (-> name (string/replace "-" "_DASH_") (munge) (string/replace "." "$"))]
+        name   (if (= "." name)
+                 "_DOT_"
+                 (-> name (string/replace "-" "_DASH_") (munge) (string/replace "." "$")))]
     (symbol (str prefix name))))
 
 (defn- register-constant!

src/test/cljs/cljs/core_test.cljs

@@ -306,7 +306,11 @@
     (is (= :a (keyword "a")))
     (is (= :a (keyword 'a)))
     (is (= :a/b (keyword 'a 'b)))
-    (is (= :a (keyword :a)))))
+    (is (= :a (keyword :a))))
+
+  (testing "Testing name munging CLJS-1432"
+    (is (not= :$ :.))
+    (is (not= '$ '.))))
 
 (deftest test-map-operations
   (testing "Test basic map collection operations"

src/test/clojure/cljs/analyzer_tests.clj

@@ -342,6 +342,12 @@
   ;; munge turns - into _, must preserve the dash first
   (is (not= (a/gen-constant-id :test-kw)
             (a/gen-constant-id :test_kw))))
+
+(deftest test-symbols-munge-cljs-1432
+  (is (not= (a/gen-constant-id :$)
+            (a/gen-constant-id :.)))
+  (is (not= (a/gen-constant-id '$)
+            (a/gen-constant-id '.))))
 ;; Constants
 
 (deftest test-constants