code cleanup on TDEPS-276

Author: puredanger

CHANGELOG.md

@@ -3,6 +3,8 @@ Changelog
 
 *Also see [Tools and installer changelog](https://github.com/clojure/brew-install/blob/1.12.4/CHANGELOG.md)*
 
+* next
+  * Code clean up on TDEPS-276
 * 0.29.1598 on Mar 3, 2026
   * TDEPS-276 - Extract source paths from local pom.xml sources defined with build-helper-maven-plugin
 * 0.29.1593 on Feb 12, 2026

src/main/clojure/clojure/tools/deps/extensions/pom.clj

@@ -136,11 +136,11 @@
       (let [^Plugin plugin (first plugins)
             extract-dirs (fn [^Plugin plugin goal ^String children]
                            (->> (.getExecutions plugin)
-                             (filter (fn [^PluginExecution exec] (.contains ^List (.getGoals exec) goal)))
+                             (filter (fn [^PluginExecution exec]
+                                       (.contains ^List (.getGoals exec) goal)))
                              (mapcat (fn [^PluginExecution exec]
-                                       (let [^Xpp3Dom config (.getConfiguration exec)
-                                             ^Xpp3Dom sources (.getChild config children)]
-                                         (map #(.getValue ^Xpp3Dom %) (.getChildren sources)))))))]
+                                       (map #(.getValue ^Xpp3Dom %)
+                                         (some-> exec .getConfiguration (Xpp3Dom/.getChild children) Xpp3Dom/.getChildren))))))]
         (concat
           (extract-dirs plugin "add-source" "sources")
           (extract-dirs plugin "add-resource" "resources"))))))

src/test/clojure/clojure/tools/deps/extensions/pom.clj

@@ -7,12 +7,12 @@
   (:import [java.io File]))
 
 (deftest tdeps-276-build-helper-src-dir
-  (let [paths (ext/coord-paths 'foo/foo {:deps/root "test-data/pom-extra-src" :deps/manifest :pom}
-                :pom {:mvn/repos maven/standard-repos})]
-    (is (contains? (set paths) (.getAbsolutePath (File. "test-data/pom-extra-src/s1"))))
-    (is (contains? (set paths) (.getAbsolutePath (File. "test-data/pom-extra-src/s2"))))
-    (is (contains? (set paths) (.getAbsolutePath (File. "test-data/pom-extra-src/r1"))))
-    (is (contains? (set paths) (.getAbsolutePath (File. "test-data/pom-extra-src/r2"))))))
+  (let [paths (set (ext/coord-paths 'foo/foo {:deps/root "test-data/pom-extra-src" :deps/manifest :pom}
+                     :pom {:mvn/repos maven/standard-repos}))]
+    (is (contains? paths (.getAbsolutePath (File. "test-data/pom-extra-src/s1"))))
+    (is (contains? paths (.getAbsolutePath (File. "test-data/pom-extra-src/s2"))))
+    (is (contains? paths (.getAbsolutePath (File. "test-data/pom-extra-src/r1"))))
+    (is (contains? paths (.getAbsolutePath (File. "test-data/pom-extra-src/r2"))))))
 
 (comment
   (tdeps-276-build-helper-src-dir)