Update README, API, and tests for new features and version bump to 1.2.0#127
Conversation
Summary of ChangesHello @cloneofghosts, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces several enhancements to the Pirate Weather Python wrapper, primarily focusing on API feature parity and improved data handling. It adds support for new query parameters and response fields from the underlying API, updates the default unit system, and refines the test suite to ensure robustness and accuracy with these changes. The package version is also incremented to reflect these new capabilities. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces several valuable updates, including support for the extraVars parameter, setting units to auto by default, and expanding the flags data. The tests have also been improved by making fixture paths more robust and skipping end-to-end tests when an API key is not available.
I've found one issue regarding how optional URL parameters are constructed, which I've detailed in a comment in pirateweather/api.py. This is a pre-existing issue that the new extraVars parameter has inherited. I've also left comments in the test files on how to adjust the tests after applying the suggested fix.
Overall, great work on adding these new features!
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request is a solid update that adds new features, improves the test suite's robustness, and bumps the project version. The changes to support auto units and the extraVars parameter are well-implemented. My review includes a few suggestions to align the new code with Python's PEP 8 naming conventions, which will improve the overall consistency and maintainability of the codebase.
1 participant
autounits as the API supports it nowFix #126