-
Notifications
You must be signed in to change notification settings - Fork 85
Add supplementary groups support and POSIX permission fixes #220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ejc3
wants to merge
18
commits into
cloud-hypervisor:master
Choose a base branch
from
ejc3:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
b05f59b
Remove all set_creds() calls from sync_io.rs
ejc3 b206a87
Replace setresuid/setresgid with setfsuid/setfsgid for credential swi…
ejc3 2548bbc
Add set_creds() to setattr for truncate and utimes
ejc3 e8118aa
Add set_creds() to all filesystem operations requiring permission checks
ejc3 d248a43
Add set_creds() to chmod operation in setattr
ejc3 c12f6d3
Add set_creds() to chown operation in setattr
ejc3 87caf46
Add set_creds() to lookup for directory search permission check
ejc3 609391a
Fix link and ftruncate operations for FUSE default_permissions
ejc3 ca5398a
Add supplementary groups support via /proc parsing
ejc3 221a76b
Use forwarded supplementary groups for remote filesystems
ejc3 7159787
Remove /proc fallback for supplementary groups
ejc3 1d089fe
Add signed lseek hook for backward-compatible negative offsets
ejc3 da79781
Format debug logging statements
ejc3 8576023
Add copy_file_range support to FileSystem trait
ejc3 956c1a6
Add remap_file_range support for FICLONE/FICLONERANGE
ejc3 3a212e5
Fix remap_file_range: proper return value and ioctl constants
ejc3 a8e8d0c
Fix ioctl type for ARM64 compatibility
ejc3 1b001da
Fix O_WRONLY open for files without read permission
ejc3 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1193,11 +1193,15 @@ impl<F: FileSystem + Sync> Server<F> { | |
| let LseekIn { | ||
| fh, offset, whence, .. | ||
| } = ctx.r.read_obj().map_err(Error::DecodeMessage)?; | ||
| let offset_signed = offset as i64; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. LseekIn is passing |
||
|
|
||
| match self | ||
| .fs | ||
| .lseek(ctx.context(), ctx.nodeid(), fh.into(), offset, whence) | ||
| { | ||
| match self.fs.lseek_signed( | ||
| ctx.context(), | ||
| ctx.nodeid(), | ||
| fh.into(), | ||
| offset_signed, | ||
| whence, | ||
| ) { | ||
| Ok(offset) => { | ||
| let out = LseekOut { offset }; | ||
|
|
||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need this signed offset? It is not part of the posix lseek definition.