Skip to content

Commit d74f494

Browse files
author
Sean Sundberg
authored
Allow NODE_ENV value to be set in container (#51)
- remove NODE_ENV argument from serve script and move to Dockerfile so that it can be overridden at deploy time Signed-off-by: Sean Sundberg <seansund@us.ibm.com>
1 parent 70b38ea commit d74f494

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ COPY --chown=1001 . .
88
RUN npm install && \
99
npm run compile
1010

11-
ENV HOST=0.0.0.0 PORT=3001
11+
ENV NODE_ENV=staging HOST=0.0.0.0 PORT=3001
1212

1313
EXPOSE ${PORT}
1414
CMD ["npm", "run", "serve"]

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,10 @@
3838
"start:dev": "NODE_ENV=dev node -r source-map-support/register .",
3939
"clean": "lb-clean dist *.tsbuildinfo .eslintcache",
4040
"rebuild": "npm run clean && npm run compile",
41-
"serve": "NODE_ENV=staging node .",
41+
"serve": "node .",
4242
"serve:dev": "NODE_ENV=dev node .",
4343
"serve:test": "NODE_ENV=test node .",
44+
"serve:staging": "NODE_ENV=staging node .",
4445
"scan": "detect-secrets scan --update .secrets.baseline --exclude-files 'package-lock.json'"
4546
},
4647
"repository": {

0 commit comments

Comments
 (0)