Skip to content

Commit c3312c3

Browse files
author
Sean Sundberg
authored
Update base image to v2.0.0 (#103)
* Update aws, azure and ibmcloud cli install logic * Remove deprecated set-output calls in workflow Signed-off-by: Sean Sundberg <seansund@us.ibm.com>
1 parent 5cd0b0f commit c3312c3

File tree

3 files changed

+67
-47
lines changed

3 files changed

+67
-47
lines changed

.github/workflows/docker-build.yaml

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,13 @@ jobs:
2020
- alpine
2121
- fedora
2222
terraform:
23-
- v1.0
24-
- v1.1
25-
- v1.2
23+
- v1.6
24+
- v1.7
25+
- v1.8
26+
- v1.9
2627

2728
env:
28-
TERRAFORM_LATEST: "v1.2"
29+
TERRAFORM_LATEST: "v1.9"
2930

3031
steps:
3132
- name: Checkout
@@ -86,25 +87,25 @@ jobs:
8687
fi
8788
8889
echo "Short terraform: ${SHORT_TERRAFORM}"
89-
echo "::set-output name=terraform::$SHORT_TERRAFORM"
90+
echo "terraform=$SHORT_TERRAFORM" >> $GITHUB_OUTPUT
9091
9192
echo "Short tag enabled: $SHORT_TAG_ENABLED"
92-
echo "::set-output name=short-enabled::$SHORT_TAG_ENABLED"
93+
echo "short-enabled=$SHORT_TAG_ENABLED" >> $GITHUB_OUTPUT
9394
9495
echo "Release tag: ${RELEASE_TAG}"
95-
echo "::set-output name=release-tag::$RELEASE_TAG"
96+
echo "release-tag=$RELEASE_TAG" >> $GITHUB_OUTPUT
9697
9798
echo "Release tag enabled: $RELEASE_TAG_ENABLED"
98-
echo "::set-output name=release-tag-enabled::$RELEASE_TAG_ENABLED"
99+
echo "release-tag-enabled=$RELEASE_TAG_ENABLED" >> $GITHUB_OUTPUT
99100
100101
echo "Release tag short enabled: $RELEASE_TAG_SHORT_ENABLED"
101-
echo "::set-output name=release-tag-short-enabled::$RELEASE_TAG_SHORT_ENABLED"
102+
echo "release-tag-short-enabled=$RELEASE_TAG_SHORT_ENABLED" >> $GITHUB_OUTPUT
102103
103104
echo "Base enabled: $BASE_ENABLED"
104-
echo "::set-output name=base-enabled::$BASE_ENABLED"
105+
echo "base-enabled=$BASE_ENABLED" >> $GITHUB_OUTPUT
105106
106107
echo "Latest enabled: $LATEST_ENABLED"
107-
echo "::set-output name=latest-enabled::$LATEST_ENABLED"
108+
echo "latest-enabled=$LATEST_ENABLED" >> $GITHUB_OUTPUT
108109
109110
- name: Docker CNTK meta ${{ matrix.base }}:${{ matrix.terraform }}
110111
id: cntk-meta

Containerfile-alpine

Lines changed: 23 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,37 +1,40 @@
1-
ARG TERRAFORM_VERSION=v1.2
2-
FROM quay.io/cloudnativetoolkit/cli-tools-core:${TERRAFORM_VERSION}-v1.6.1-alpine
1+
ARG TERRAFORM_VERSION=v1.9
2+
FROM quay.io/cloudnativetoolkit/cli-tools-core:${TERRAFORM_VERSION}-v2.0.0-alpine
33

44
ARG TARGETPLATFORM
55

66
ENV TF_CLI_ARGS_apply="-parallelism=6"
77

8+
USER root
9+
810
## AWS cli
9-
RUN sudo apk add --no-cache \
11+
RUN apk add --no-cache --force-broken-world \
12+
aws-cli && \
13+
rm -rf /var/cache/apk/*
14+
15+
## Azure cli
16+
RUN apk add --no-cache --force-broken-world \
1017
python3 \
1118
py3-pip \
12-
&& sudo pip3 install --upgrade pip \
13-
&& sudo pip3 install awscli \
14-
&& sudo rm -rf /var/cache/apk/* \
15-
&& aws --version
19+
gcc \
20+
musl-dev \
21+
python3-dev \
22+
libffi-dev \
23+
openssl-dev \
24+
cargo \
25+
make && \
26+
rm -rf /var/cache/apk/* && \
27+
pip3 install --upgrade --break-system-packages pip
1628

17-
## Azure cli
18-
RUN sudo apk add gcc musl-dev python3-dev libffi-dev openssl-dev cargo make python3 py3-pip \
19-
&& sudo pip3 install --upgrade pip \
20-
&& sudo pip3 install azure-cli \
21-
&& sudo rm -rf /var/cache/apk/* \
22-
&& az --version
29+
USER devops
30+
31+
RUN pip3 install --break-system-packages azure-cli
2332

2433
# Install the ibmcloud cli
2534
RUN curl -fsSL https://clis.cloud.ibm.com/install/linux | sh && \
2635
ibmcloud plugin install container-service -f && \
2736
ibmcloud plugin install container-registry -f && \
2837
ibmcloud plugin install observe-service -f && \
29-
if [[ "$TARGETPLATFORM" != "linux/arm64" ]]; then ibmcloud plugin install vpc-infrastructure -f; fi && \
38+
ibmcloud plugin install vpc-infrastructure -f && \
3039
ibmcloud config --check-version=false && \
3140
chmod -R g=u ${HOME}
32-
33-
WORKDIR ${HOME}
34-
35-
VOLUME /workspaces
36-
37-
ENTRYPOINT ["/bin/sh"]

Containerfile-fedora

Lines changed: 32 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,47 @@
1-
ARG TERRAFORM_VERSION=v1.2
2-
FROM quay.io/cloudnativetoolkit/cli-tools-core:${TERRAFORM_VERSION}-v1.6.1-fedora
1+
ARG TERRAFORM_VERSION=v1.9
2+
FROM quay.io/cloudnativetoolkit/cli-tools-core:${TERRAFORM_VERSION}-v2.0.0-fedora
33

44
ARG TARGETPLATFORM
55

66
ENV TF_CLI_ARGS_apply="-parallelism=6"
77

8+
USER root
9+
810
## AWS cli
9-
RUN sudo dnf install -y \
10-
python3 \
11-
python3-pip \
12-
&& sudo pip3 install --upgrade pip \
13-
&& sudo pip3 install awscli \
14-
&& sudo dnf clean all \
15-
&& aws --version
11+
RUN dnf install -y \
12+
awscli && \
13+
dnf clean all
1614

1715
## Azure cli
18-
RUN sudo rpm --import https://packages.microsoft.com/keys/microsoft.asc && \
19-
sudo dnf install -y https://packages.microsoft.com/config/rhel/8/packages-microsoft-prod.rpm && \
20-
sudo dnf install -y azure-cli && \
21-
sudo dnf clean all && \
22-
az --version
16+
RUN dnf install -y \
17+
python3 \
18+
pip3 \
19+
gcc \
20+
musl-devel \
21+
python3-devel \
22+
libffi-devel \
23+
openssl-devel \
24+
cargo \
25+
make && \
26+
dnf clean all && \
27+
pip3 install --upgrade --break-system-packages pip
28+
29+
USER devops
30+
31+
# Azure cli
32+
RUN pip3 install --break-system-packages azure-cli
2333

2434
# Install the ibmcloud cli
35+
36+
USER root
37+
2538
RUN curl -fsSL https://clis.cloud.ibm.com/install/linux | sh && \
2639
ibmcloud plugin install container-service -f && \
2740
ibmcloud plugin install container-registry -f && \
2841
ibmcloud plugin install observe-service -f && \
29-
if [[ "$TARGETPLATFORM" != "linux/arm64" ]]; then ibmcloud plugin install vpc-infrastructure -f; fi && \
42+
ibmcloud plugin install vpc-infrastructure -f && \
3043
ibmcloud config --check-version=false && \
31-
chmod -R g=u ${HOME}
44+
chown -R devops ${HOME}/.bluemix && \
45+
chmod -R g=u ${HOME}/.bluemix
46+
47+
USER devops

0 commit comments

Comments
 (0)