Address CodeRabbit review: fix test count, scope share cleanup, preserve hide_download=0

Author: bigcat88

PROGRESS.md

@@ -64,4 +64,4 @@
 | State | — | 2 |
 | Shares | 5 | 40 |
 | System Tags | 6 | 22 |
-| **Total** | **47** | **356** |
+| **Total** | **47** | **358** |

src/nextcloud_mcp/tools/shares.py

@@ -33,7 +33,7 @@ def _format_share(share: dict[str, Any]) -> dict[str, Any]:
         result["url"] = share["url"]
     if share.get("password"):
         result["has_password"] = True
-    if share.get("hide_download"):
+    if "hide_download" in share:
         result["hide_download"] = share["hide_download"]
     return result
 

tests/integration/conftest.py

@@ -142,6 +142,9 @@ async def _cleanup(client: NextcloudClient) -> None:
     with contextlib.suppress(Exception):
         shares = await client.ocs_get("apps/files_sharing/api/v1/shares")
         for share in shares:
+            share_path = str(share.get("path", ""))
+            if share_path != f"/{TEST_BASE_DIR}" and not share_path.startswith(f"/{TEST_BASE_DIR}/"):
+                continue
             with contextlib.suppress(Exception):
                 await client.ocs_delete(f"apps/files_sharing/api/v1/shares/{share['id']}")
     with contextlib.suppress(Exception):

tests/integration/test_shares.py

@@ -303,7 +303,7 @@ async def test_update_disable_hide_download(self, nc_mcp: McpTestHelper) -> None
         await nc_mcp.call("update_share", share_id=share_id, hide_download=True)
         result = await nc_mcp.call("update_share", share_id=share_id, hide_download=False)
         updated = json.loads(result)
-        assert not updated.get("hide_download")
+        assert updated["hide_download"] == 0
 
     @pytest.mark.asyncio
     async def test_update_disable_public_upload(self, nc_mcp: McpTestHelper) -> None: