Remove decorative separator comments from test files, add style rule

Author: bigcat88

GUIDANCE.md

@@ -8,6 +8,7 @@ Rules and corrections for writing code in this project.
 - Never import inside functions. All imports must be at the top of the file.
 - Never use `# noqa: F401` — if something is imported, it must be used.
 - Maximum line length is 120 characters.
+- No decorative/separator comments (e.g. `# -----------` section banners). Code structure should be self-evident. Only add comments that explain *why*, never *what*.
 
 ## Tooling
 

tests/integration/test_talk.py

@@ -17,11 +17,6 @@
 pytestmark = pytest.mark.integration
 
 
-# ---------------------------------------------------------------------------
-# Helpers
-# ---------------------------------------------------------------------------
-
-
 async def _create_room(nc_mcp: McpTestHelper, name: str, room_type: int = 2) -> dict[str, Any]:
     """Create a conversation and return the parsed result."""
     result = await nc_mcp.call("create_conversation", room_type=room_type, name=name)
@@ -51,11 +46,6 @@ def _extract_message_id(line: str) -> int:
     return int(match.group(1))
 
 
-# ---------------------------------------------------------------------------
-# list_conversations
-# ---------------------------------------------------------------------------
-
-
 class TestListConversations:
     @pytest.mark.asyncio
     async def test_returns_json_list(self, nc_mcp: McpTestHelper) -> None:
@@ -103,11 +93,6 @@ async def test_conversation_type_labels(self, nc_mcp: McpTestHelper) -> None:
             await _delete_room(nc_mcp, str(public_room["token"]))
 
 
-# ---------------------------------------------------------------------------
-# get_conversation
-# ---------------------------------------------------------------------------
-
-
 class TestGetConversation:
     @pytest.mark.asyncio
     async def test_returns_conversation_details(self, nc_mcp: McpTestHelper) -> None:
@@ -136,11 +121,6 @@ async def test_returns_read_only_status(self, nc_mcp: McpTestHelper) -> None:
             await _delete_room(nc_mcp, str(room["token"]))
 
 
-# ---------------------------------------------------------------------------
-# get_messages (compact format)
-# ---------------------------------------------------------------------------
-
-
 class TestGetMessages:
     @pytest.mark.asyncio
     async def test_returns_compact_format(self, nc_mcp: McpTestHelper) -> None:
@@ -283,11 +263,6 @@ async def test_compact_format_saves_space(self, nc_mcp: McpTestHelper) -> None:
             await _delete_room(nc_mcp, str(room["token"]))
 
 
-# ---------------------------------------------------------------------------
-# get_participants
-# ---------------------------------------------------------------------------
-
-
 class TestGetParticipants:
     @pytest.mark.asyncio
     async def test_returns_participants_list(self, nc_mcp: McpTestHelper) -> None:
@@ -330,11 +305,6 @@ async def test_nonexistent_conversation_raises(self, nc_mcp: McpTestHelper) -> N
             await nc_mcp.call("get_participants", token="nonexistent-xyz-12345")
 
 
-# ---------------------------------------------------------------------------
-# send_message
-# ---------------------------------------------------------------------------
-
-
 class TestSendMessage:
     @pytest.mark.asyncio
     async def test_send_basic_message(self, nc_mcp: McpTestHelper) -> None:
@@ -413,11 +383,6 @@ async def test_sent_message_appears_in_get_messages(self, nc_mcp: McpTestHelper)
             await _delete_room(nc_mcp, str(room["token"]))
 
 
-# ---------------------------------------------------------------------------
-# create_conversation
-# ---------------------------------------------------------------------------
-
-
 class TestCreateConversation:
     @pytest.mark.asyncio
     async def test_create_group_conversation(self, nc_mcp: McpTestHelper) -> None:
@@ -479,11 +444,6 @@ async def test_creator_is_participant(self, nc_mcp: McpTestHelper) -> None:
             await _delete_room(nc_mcp, str(data["token"]))
 
 
-# ---------------------------------------------------------------------------
-# delete_message
-# ---------------------------------------------------------------------------
-
-
 class TestDeleteMessage:
     @pytest.mark.asyncio
     async def test_delete_own_message(self, nc_mcp: McpTestHelper) -> None:
@@ -522,11 +482,6 @@ async def test_delete_in_nonexistent_conversation_raises(self, nc_mcp: McpTestHe
             await nc_mcp.call("delete_message", token="nonexistent-xyz-12345", message_id=1)
 
 
-# ---------------------------------------------------------------------------
-# leave_conversation
-# ---------------------------------------------------------------------------
-
-
 class TestLeaveConversation:
     @pytest.mark.asyncio
     async def test_leave_group_conversation(self, nc_mcp: McpTestHelper) -> None:
@@ -557,11 +512,6 @@ async def test_leave_nonexistent_conversation_raises(self, nc_mcp: McpTestHelper
             await nc_mcp.call("leave_conversation", token="nonexistent-xyz-12345")
 
 
-# ---------------------------------------------------------------------------
-# Permission enforcement
-# ---------------------------------------------------------------------------
-
-
 class TestTalkPermissions:
     @pytest.mark.asyncio
     async def test_read_only_allows_list_conversations(self, nc_mcp_read_only: McpTestHelper) -> None:

tests/integration/test_talk_polls.py

@@ -11,11 +11,6 @@
 pytestmark = pytest.mark.integration
 
 
-# ---------------------------------------------------------------------------
-# Helpers
-# ---------------------------------------------------------------------------
-
-
 async def _create_room(nc_mcp: McpTestHelper, name: str, room_type: int = 2) -> dict[str, Any]:
     """Create a conversation and return the parsed result."""
     result = await nc_mcp.call("create_conversation", room_type=room_type, name=name)
@@ -49,11 +44,6 @@ async def _create_test_poll(
     return json.loads(result)
 
 
-# ---------------------------------------------------------------------------
-# create_poll
-# ---------------------------------------------------------------------------
-
-
 class TestCreatePoll:
     @pytest.mark.asyncio
     async def test_create_basic_poll(self, nc_mcp: McpTestHelper) -> None:
@@ -149,11 +139,6 @@ async def test_create_poll_initial_state(self, nc_mcp: McpTestHelper) -> None:
             await _delete_room(nc_mcp, str(room["token"]))
 
 
-# ---------------------------------------------------------------------------
-# get_poll
-# ---------------------------------------------------------------------------
-
-
 class TestGetPoll:
     @pytest.mark.asyncio
     async def test_get_poll_returns_details(self, nc_mcp: McpTestHelper) -> None:
@@ -220,11 +205,6 @@ async def test_get_poll_reflects_votes(self, nc_mcp: McpTestHelper) -> None:
             await _delete_room(nc_mcp, str(room["token"]))
 
 
-# ---------------------------------------------------------------------------
-# vote_poll
-# ---------------------------------------------------------------------------
-
-
 class TestVotePoll:
     @pytest.mark.asyncio
     async def test_vote_single_option(self, nc_mcp: McpTestHelper) -> None:
@@ -317,11 +297,6 @@ async def test_vote_on_closed_poll_raises(self, nc_mcp: McpTestHelper) -> None:
             await _delete_room(nc_mcp, str(room["token"]))
 
 
-# ---------------------------------------------------------------------------
-# close_poll
-# ---------------------------------------------------------------------------
-
-
 class TestClosePoll:
     @pytest.mark.asyncio
     async def test_close_poll(self, nc_mcp: McpTestHelper) -> None:
@@ -388,11 +363,6 @@ async def test_close_poll_preserves_question_and_options(self, nc_mcp: McpTestHe
             await _delete_room(nc_mcp, str(room["token"]))
 
 
-# ---------------------------------------------------------------------------
-# Permission enforcement
-# ---------------------------------------------------------------------------
-
-
 class TestPollPermissions:
     @pytest.mark.asyncio
     async def test_read_only_allows_get_poll(self, nc_mcp_read_only: McpTestHelper) -> None: