Merge branch 'main' into refactor/drop-sync-notes-weather-userstatus-activity

Signed-off-by: Alexander Piskun <13381981+bigcat88@users.noreply.github.com>

Author: bigcat88

.github/workflows/father.yml

@@ -0,0 +1,50 @@
+name: Father
+
+on:
+  issue_comment:
+    types: [created]
+  pull_request_review_comment:
+    types: [created]
+  issues:
+    types: [opened, assigned]
+  pull_request_review:
+    types: [submitted]
+
+jobs:
+  father:
+    if: |
+      (github.event_name == 'issue_comment' && contains(github.event.comment.body, '@father')) ||
+      (github.event_name == 'pull_request_review_comment' && contains(github.event.comment.body, '@father')) ||
+      (github.event_name == 'pull_request_review' && contains(github.event.review.body, '@father')) ||
+      (github.event_name == 'issues' && (contains(github.event.issue.body, '@father') || contains(github.event.issue.title, '@father')))
+    runs-on: ubuntu-latest
+    permissions:
+      contents: read
+      pull-requests: read
+      issues: read
+      id-token: write
+      actions: read
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        with:
+          fetch-depth: 1
+
+      - name: Run Father
+        id: father
+        uses: anthropics/claude-code-action@edd85d61533cbba7b57ed0ca4af1750b1fdfd3c4 # v1
+        with:
+          trigger_phrase: '@father'
+          claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
+          additional_permissions: |
+            actions: read
+          claude_args: >-
+            --system-prompt "You are Father — strict, demanding, and uncompromising on quality.
+            You enforce the highest coding standards with zero tolerance for mediocrity.
+            Never accept good enough — push for excellence in every line.
+            Point out every deviation from best practices directly and bluntly.
+            Do not sugarcoat. If the code is subpar, say so and explain what excellence looks like.
+            Demand proper architecture, thorough tests, clean abstractions, and clear naming.
+            No shortcuts. No excuses. Raise the bar.
+            Do not include a Summary section.
+            Do not include any claude.ai deep links or 'Explore this' links in your response."

.github/workflows/mother.yml

@@ -0,0 +1,53 @@
+name: Mother
+
+on:
+  issue_comment:
+    types: [created]
+  pull_request_review_comment:
+    types: [created]
+  issues:
+    types: [opened, assigned]
+  pull_request_review:
+    types: [submitted]
+
+jobs:
+  mother:
+    if: |
+      (github.event_name == 'issue_comment' && contains(github.event.comment.body, '@mother')) ||
+      (github.event_name == 'pull_request_review_comment' && contains(github.event.comment.body, '@mother')) ||
+      (github.event_name == 'pull_request_review' && contains(github.event.review.body, '@mother')) ||
+      (github.event_name == 'issues' && (contains(github.event.issue.body, '@mother') || contains(github.event.issue.title, '@mother')))
+    runs-on: ubuntu-latest
+    permissions:
+      contents: read
+      pull-requests: read
+      issues: read
+      id-token: write
+      actions: read
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        with:
+          fetch-depth: 1
+
+      - name: Run Mother
+        id: mother
+        uses: anthropics/claude-code-action@edd85d61533cbba7b57ed0ca4af1750b1fdfd3c4 # v1
+        with:
+          trigger_phrase: '@mother'
+          claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
+          additional_permissions: |
+            actions: read
+          claude_args: >-
+            --system-prompt "You are Mother — a warm, nurturing, and patient mentor.
+            Always open by genuinely celebrating what was done well before offering any suggestions.
+            Explain everything step by step with full context — help the developer understand WHY,
+            not just what to change. Be encouraging and supportive while remaining technically precise.
+            When pointing out issues, frame them as learning opportunities and use only these two priority levels:
+            'Important to address' for things that should be fixed before merging,
+            and 'Worth considering if time allows' for nice-to-have improvements.
+            Never use labels like Critical, High, Medium, or Low severity.
+            Guide gently: Have you considered, A nice approach here would be, One thing worth thinking about.
+            Do not include a Summary section.
+            Do not include any claude.ai deep links or 'Explore this' links in your response.
+            Your goal is to help developers grow, not just to fix code."

.pre-commit-config.yaml

@@ -20,7 +20,8 @@ repos:
                 nc_py_api/|
                 benchmarks/|
                 examples/|
-                tests/
+                tests/|
+                tests_unit/
             )
 
 -   repo: https://github.com/psf/black
@@ -32,7 +33,8 @@ repos:
                 nc_py_api/|
                 benchmarks/|
                 examples/|
-                tests/
+                tests/|
+                tests_unit/
             )
 
 -   repo: https://github.com/tox-dev/pyproject-fmt

CHANGELOG.md

@@ -2,6 +2,19 @@
 
 All notable changes to this project will be documented in this file.
 
+## [0.24.2 - 2026-03-02]
+
+### Changed
+
+- Use new `/ex-app/status` endpoint for `set_init_status` instead of deprecated `/apps/status/{appId}`
+
+## [0.24.1 - 2026-02-25]
+
+### Fixed
+
+- ExApps: Use FileLock with atomic rename for safe concurrent model downloads. #396
+- Upgrade `caldav` dependency for `icalendar` 7.x compatibility. #397
+
 ## [0.24.0 - 2026-02-04]
 
 ### Added

nc_py_api/_version.py

@@ -1,3 +1,3 @@
 """Version of nc_py_api."""
 
-__version__ = "0.30.0"
+__version__ = "0.30.0.dev0"

nc_py_api/ex_app/integration_fastapi.py

@@ -20,6 +20,8 @@
     status,
 )
 from fastapi.responses import JSONResponse, PlainTextResponse
+from filelock import FileLock
+from filelock import Timeout as FileLockTimeout
 from starlette.requests import HTTPConnection, Request
 from starlette.types import ASGIApp, Receive, Scope, Send
 
@@ -158,7 +160,7 @@ def fetch_models_task(nc: NextcloudApp, models: dict[str, dict], progress_init_s
     """Use for cases when you want to define custom `/init` but still need to easy download models.
 
     :param nc: NextcloudApp instance.
-    :param models_to_fetch: Dictionary describing which models should be downloaded of the form:
+    :param models: Dictionary describing which models should be downloaded of the form:
         .. code-block:: python
             {
                 "model_url_1": {
@@ -205,42 +207,56 @@ def __fetch_model_as_file(
     current_progress: int, progress_for_task: int, nc: NextcloudApp, model_path: str, download_options: dict
 ) -> str:
     result_path = download_options.pop("save_path", urlparse(model_path).path.split("/")[-1])
-    with niquests.get(model_path, stream=True) as response:
-        if not response.ok:
-            raise ModelFetchError(
-                f"Downloading of '{model_path}' failed, returned ({response.status_code}) {response.text}"
-            )
-        downloaded_size = 0
-        linked_etag = ""
-        for each_history in response.history:
-            linked_etag = each_history.headers.get("X-Linked-ETag", "")
-            if linked_etag:
-                break
-        if not linked_etag:
-            linked_etag = response.headers.get("X-Linked-ETag", response.headers.get("ETag", ""))
-        total_size = int(response.headers.get("Content-Length"))
-        try:
-            existing_size = os.path.getsize(result_path)
-        except OSError:
-            existing_size = 0
-        if linked_etag and total_size == existing_size:
-            with builtins.open(result_path, "rb") as file:
-                sha256_hash = hashlib.sha256()
-                for byte_block in iter(lambda: file.read(4096), b""):
-                    sha256_hash.update(byte_block)
-                if f'"{sha256_hash.hexdigest()}"' == linked_etag:
-                    nc.set_init_status(min(current_progress + progress_for_task, 99))
-                    return result_path
-
-        with builtins.open(result_path, "wb") as file:
-            last_progress = current_progress
-            for chunk in response.iter_raw(-1):
-                downloaded_size += file.write(chunk)
-                if total_size:
-                    new_progress = min(current_progress + int(progress_for_task * downloaded_size / total_size), 99)
-                    if new_progress != last_progress:
-                        nc.set_init_status(new_progress)
-                        last_progress = new_progress
+    tmp_path = result_path + ".tmp"
+    try:
+        with FileLock(result_path + ".lock", timeout=7200), niquests.get(model_path, stream=True) as response:
+            if not response.ok:
+                raise ModelFetchError(
+                    f"Downloading of '{model_path}' failed, returned ({response.status_code}) {response.text}"
+                )
+            downloaded_size = 0
+            linked_etag = ""
+            for redirect_resp in response.history:
+                linked_etag = redirect_resp.headers.get("X-Linked-ETag", "")
+                if linked_etag:
+                    break
+            if not linked_etag:
+                linked_etag = response.headers.get("X-Linked-ETag", response.headers.get("ETag", ""))
+            total_size = int(response.headers.get("Content-Length", 0))
+            try:
+                existing_size = os.path.getsize(result_path)
+            except OSError:
+                existing_size = 0
+            if linked_etag and total_size and total_size == existing_size:
+                with builtins.open(result_path, "rb") as file:
+                    sha256_hash = hashlib.sha256()
+                    for byte_block in iter(lambda: file.read(4096), b""):
+                        sha256_hash.update(byte_block)
+                    if f'"{sha256_hash.hexdigest()}"' == linked_etag:
+                        nc.set_init_status(min(current_progress + progress_for_task, 99))
+                        return result_path
+
+            try:
+                with builtins.open(tmp_path, "wb") as file:
+                    last_progress = current_progress
+                    for chunk in response.iter_raw(-1):
+                        downloaded_size += file.write(chunk)
+                        if total_size:
+                            new_progress = min(
+                                current_progress + int(progress_for_task * downloaded_size / total_size), 99
+                            )
+                            if new_progress != last_progress:
+                                nc.set_init_status(new_progress)
+                                last_progress = new_progress
+                os.replace(tmp_path, result_path)
+            except BaseException:
+                if os.path.exists(tmp_path):
+                    os.remove(tmp_path)
+                raise
+    except FileLockTimeout as exc:
+        raise ModelFetchError(
+            f"Timed out waiting for lock on '{result_path}' after 7200s — another process may be stuck downloading"
+        ) from exc
 
     return result_path
 

nc_py_api/nextcloud.py

@@ -418,7 +418,7 @@ def set_init_status(self, progress: int, error: str = "") -> None:
         """
         self._session.ocs(
             "PUT",
-            f"/ocs/v1.php/apps/app_api/apps/status/{self._session.cfg.app_name}",
+            "/ocs/v1.php/apps/app_api/ex-app/status",
             json={
                 "progress": progress,
                 "error": error,
@@ -552,7 +552,7 @@ async def set_init_status(self, progress: int, error: str = "") -> None:
         """
         await self._session.ocs(
             "PUT",
-            f"/ocs/v1.php/apps/app_api/apps/status/{self._session.cfg.app_name}",
+            "/ocs/v1.php/apps/app_api/ex-app/status",
             json={
                 "progress": progress,
                 "error": error,

pyproject.toml

@@ -46,6 +46,7 @@ dynamic = [
 ]
 dependencies = [
   "fastapi>=0.109.2",
+  "filelock>=3.20.3,<4",
   "niquests>=3,<4",
   "pydantic>=2.1.1",
   "python-dotenv>=1",
@@ -148,6 +149,12 @@ lint.extend-per-file-ignores."tests/**/*.py" = [
   "S",
   "UP",
 ]
+lint.extend-per-file-ignores."tests_unit/**/*.py" = [
+  "D",
+  "E402",
+  "S",
+  "UP",
+]
 lint.mccabe.max-complexity = 16
 
 [tool.isort]
@@ -198,6 +205,7 @@ messages_control.disable = [
 minversion = "6.0"
 testpaths = [
   "tests",
+  "tests_unit",
 ]
 filterwarnings = [
   "ignore::DeprecationWarning",

tests/actual_tests/files_sharing_test.py

@@ -205,7 +205,7 @@ def test_create_expire_time(nc):
     expire_time = expire_time.replace(hour=0, minute=0, second=0, microsecond=0)
     new_share = nc.files.sharing.create("test_12345_text.txt", ShareType.TYPE_LINK, expire_date=expire_time)
     nc.files.sharing.delete(new_share)
-    assert new_share.expire_date == expire_time
+    assert new_share.expire_date.date() == expire_time.date()
     with pytest.raises(NextcloudException):
         nc.files.sharing.create(
             "test_12345_text.txt", ShareType.TYPE_LINK, expire_date=datetime.datetime.now() - datetime.timedelta(days=1)
@@ -221,7 +221,7 @@ async def test_create_expire_time_async(anc):
     expire_time = expire_time.replace(hour=0, minute=0, second=0, microsecond=0)
     new_share = await anc.files.sharing.create("test_12345_text.txt", ShareType.TYPE_LINK, expire_date=expire_time)
     await anc.files.sharing.delete(new_share)
-    assert new_share.expire_date == expire_time
+    assert new_share.expire_date.date() == expire_time.date()
     with pytest.raises(NextcloudException):
         await anc.files.sharing.create(
             "test_12345_text.txt", ShareType.TYPE_LINK, expire_date=datetime.datetime.now() - datetime.timedelta(days=1)
@@ -295,7 +295,7 @@ def test_create_update(nc):
     expire_time = datetime.datetime.now() + datetime.timedelta(days=1)
     expire_time = expire_time.replace(hour=0, minute=0, second=0, microsecond=0)
     update_share = nc.files.sharing.update(new_share, expire_date=expire_time)
-    assert update_share.expire_date == expire_time
+    assert update_share.expire_date.date() == expire_time.date()
     update_share = nc.files.sharing.update(new_share, note="note", label="label")
     assert update_share.note == "note"
     assert update_share.label == "label"
@@ -328,7 +328,7 @@ async def test_create_update_async(anc):
     expire_time = datetime.datetime.now() + datetime.timedelta(days=1)
     expire_time = expire_time.replace(hour=0, minute=0, second=0, microsecond=0)
     update_share = await anc.files.sharing.update(new_share, expire_date=expire_time)
-    assert update_share.expire_date == expire_time
+    assert update_share.expire_date.date() == expire_time.date()
     update_share = await anc.files.sharing.update(new_share, note="note", label="label")
     assert update_share.note == "note"
     assert update_share.label == "label"