Skip to content

Commit e655287

Browse files
oleksandr-ncReview
andauthored
ci: keep Notes app compatible across the stable31/32/33 matrix (#436)
The two `Checkout Notes` steps pin the Notes app to `ref: "main"`. Notes `main` is now `v5.0.0` with `min-version="33"`, so `occ app:enable notes` fails on the older servers and the `stable31` (Client) and `stable32` (Maria) jobs go red at the `Enable Notes` step. This has nothing to do with the changes of the PR it runs on, so right now it breaks CI on every open PR. `nextcloud/notes` has no server matched stable branches, so the ref is now chosen by server version: `stable31` and `stable32` use the last `4.x` tag `v4.13.1` (supports NC 28 to 34), while `stable33` and newer keep `main` so the latest Notes stays under test. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit This release contains no user-facing changes. The updates involve internal continuous integration workflow configurations to improve compatibility with different Nextcloud versions. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: Review <review@local>
1 parent 9d15e79 commit e655287

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

.github/workflows/analysis-coverage.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,8 @@ jobs:
203203
uses: actions/checkout@v6
204204
with:
205205
repository: nextcloud/notes
206-
ref: "main"
206+
# Notes main (v5.0.0) requires NC >= 33; pin older servers to the last 4.x (supports NC 28-34).
207+
ref: "${{ (matrix.nextcloud == 'stable31' || matrix.nextcloud == 'stable32') && 'v4.13.1' || 'main' }}"
207208
path: apps/notes
208209

209210
- name: Checkout Files Locking
@@ -548,7 +549,8 @@ jobs:
548549
uses: actions/checkout@v6
549550
with:
550551
repository: nextcloud/notes
551-
ref: "main"
552+
# Notes main (v5.0.0) requires NC >= 33; pin older servers to the last 4.x (supports NC 28-34).
553+
ref: "${{ (matrix.nextcloud == 'stable31' || matrix.nextcloud == 'stable32') && 'v4.13.1' || 'main' }}"
552554
path: apps/notes
553555

554556
- name: Checkout Files Locking

0 commit comments

Comments
 (0)