Skip to content

fix: handle string "false" from xmltodict in download URL parsing

8ea2767
Select commit
Loading
Failed to load commit list.
Merged

feat: expose S3 presigned download URL on FsNode #419

fix: handle string "false" from xmltodict in download URL parsing
8ea2767
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 25, 2026 in 1s

94.73% (+0.04%) compared to ef519ae

View this Pull Request on Codecov

94.73% (+0.04%) compared to ef519ae

Details

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.73%. Comparing base (ef519ae) to head (8ea2767).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #419      +/-   ##
==========================================
+ Coverage   94.69%   94.73%   +0.04%     
==========================================
  Files          47       48       +1     
  Lines        5575     5625      +50     
==========================================
+ Hits         5279     5329      +50     
  Misses        296      296              
Files with missing lines Coverage Δ
nc_py_api/files/__init__.py 99.71% <100.00%> (+<0.01%) ⬆️
nc_py_api/files/_files.py 96.53% <100.00%> (+0.12%) ⬆️
tests_unit/test_download_url.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.