Skip to content

Commit 6becd3b

Browse files
authored
Merge pull request #395 from smiclea/fix-edit-layout
Fix Edit Replica modal layout issues
2 parents 174128a + 8132c41 commit 6becd3b

3 files changed

Lines changed: 6 additions & 1 deletion

File tree

src/components/molecules/PropertiesTable/PropertiesTable.jsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ type Props = {
6363
properties: Field[],
6464
onChange: (property: Field, value: any) => void,
6565
valueCallback: (property: Field) => any,
66+
hideRequiredSymbol?: boolean,
6667
}
6768
@observer
6869
class PropertiesTable extends React.Component<Props> {
@@ -95,7 +96,7 @@ class PropertiesTable extends React.Component<Props> {
9596
value={this.props.valueCallback(prop)}
9697
onChange={e => { this.props.onChange(prop, e.target.value) }}
9798
placeholder={this.getName(prop.name)}
98-
required={typeof prop.required === 'boolean' ? prop.required : false}
99+
required={typeof prop.required === 'boolean' && !this.props.hideRequiredSymbol ? prop.required : false}
99100
/>
100101
)
101102
}
@@ -135,6 +136,7 @@ class PropertiesTable extends React.Component<Props> {
135136
selectedItem={selectedItem}
136137
items={items}
137138
onChange={item => this.props.onChange(prop, item.value)}
139+
required={typeof prop.required === 'boolean' && !this.props.hideRequiredSymbol ? prop.required : false}
138140
/>
139141
)
140142
}

src/components/molecules/WizardOptionsField/WizardOptionsField.jsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,7 @@ class WizardOptionsField extends React.Component<Props> {
115115
properties={this.props.properties}
116116
valueCallback={this.props.valueCallback}
117117
onChange={this.props.onChange}
118+
hideRequiredSymbol
118119
data-test-id="wOptionsField-propertiesTable"
119120
/>
120121
)

src/utils/LabelDictionary.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,8 @@ const dictionary = {
5151
storage_endpoint: 'Storage Endpoint Suffix',
5252
preserve_nic_ips: 'Preserve NIC IPs',
5353
openstack_use_current_user: 'Use Current User/Project/Domain for Authentification',
54+
windows_os_image: 'Windows OS',
55+
linux_os_image: 'Linux OS',
5456
}
5557

5658
const cache: { name: string, label: ?string, description: ?string }[] = []

0 commit comments

Comments
 (0)