Merge pull request #14 from fabi200123/json-schema

 Adding unit-tests and json schema validation

Author: gabriel-samfira

.github/workflows/go-tests.yml

@@ -0,0 +1,44 @@
+name: Go Tests
+
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+    branches:
+      - main
+
+jobs:
+  go-tests-linux:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+
+      - name: Setup Golang
+        uses: actions/setup-go@v3
+        with:
+          go-version-file: go.mod
+
+      - run: go version
+
+      - name: Run GARM Go Tests
+        run: make go-test
+
+  go-tests-windows:
+    runs-on: windows-latest
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+
+      - name: Setup Golang
+        uses: actions/setup-go@v3
+        with:
+          go-version-file: go.mod
+
+      - run: go version
+
+      - name: Run GARM Go Tests
+        run: go test -tags testing -v ./... -timeout=15m -parallel=4

README.md

@@ -32,6 +32,7 @@ Garm supports sending opaque json encoded configs to the IaaS providers it hooks
 To this end, this provider supports the following extra specs schema:
 
 ```json
+
 {
     "$schema": "http://cloudbase.it/garm-provider-openstack/schemas/extra_specs#",
     "type": "object",
@@ -65,16 +66,21 @@ To this end, this provider supports the following extra specs schema:
         },
         "enable_boot_debug": {
             "type": "boolean",
-            "description": "Enable cloud-init debug mode. Adds `set -x` into the cloud-init script."
+            "description": "Enable cloud-init debug mode. Adds 'set -x' into the cloud-init script."
         },
-        "allow_image_owners": {
+        "allowed_image_owners": {
             "type": "array",
             "items": {
                 "type": "string"
             },
             "description": "A list of image owners to allow when creating the instance. If not specified, all images will be allowed." 
-        }
-    }
+        },
+		"image_visibility": {
+			"type": "string",
+			"description": "The visibility of the image to use."
+		}
+    },
+	"additionalProperties": false
 }
 ```
 

client/client.go

@@ -450,7 +450,7 @@ func (o *OpenstackClient) StartServer(nameOrID string) error {
 	}
 
 	if err := startstop.Start(o.compute, srv.ID).ExtractErr(); err != nil {
-		return fmt.Errorf("failed to stop server: %w", err)
+		return fmt.Errorf("failed to start server: %w", err)
 	}
 
 	return nil