Create Repo / Org make --forge-type optional

[ChristopherHX]

• This makes gitea garm usage unnessary complex

[gabriel-samfira]

As I wanted to submit a comment, you pushed a commit that solved that comment and GH erred out because of the outdated commit I was commenting on 😄 .

This LGTM. If tests pass, we can merge.

[gabriel-samfira]

To fix the lint error, you can probably run:

golangci-lint run --build-tags=testing --fix

run:

make install-lint-deps

to get the needed binaries.

To run the tests locally, you can run:

make test

[ChristopherHX]

To run the tests locally, you can run:

make test

Not so easy, on my system.

It's much easier for me once the CI does no longer need approval, maybe for the second PR.

Linter complained about unused functions as well, maybe your version is an older v1. v2 is not compatible at all

[ChristopherHX]

This passed locally

go test ./... -tags testing

make test
more like, due to linuxism

/bin/bash: line 0: cd: /var/folders/yt/nn49l1_57rb2bbtj13r8yc040000gn/T/tmp.mFOQBSGnO5/garm: No such file or directory

I force pushed only, because you do not seem to use my preferred squash merging strategy

[gabriel-samfira]

more like, due to linuxism

probably due to the shell used. Changing:

garm/Makefile

Line 70 in 18ef27b

@cp -R ${ROOTDIR} ${TMPDIR}

to

@cp -R ${ROOTDIR} ${TMPDIR}/.

will make it work on your system as well.

[gabriel-samfira]

Thanks!

[ChristopherHX]

probably due to the shell used. Changing:

Actually not, this was for example macOS and the error is of a different kind.

For lxd, I remote patched garm on my ubuntu arm64 server. I am testing with the k8s provider to not have to use my old windows/linux laptop with weak battery or doing remote development.

[gabriel-samfira]

Actually not, this was for example macOS and the error is of a different kind.

if you have a bit of RAM to spare, you could probably use multipass on Mac to get a quick ubuntu VM up and running locally.