Skip to content

Commit 8901256

Browse files
petrutlucian94Dany9966
authored andcommitted
Bump hacking dependency and remove noqa comments
Older flake8/pycodestyle versions weren't able to properly handle f strings, so we had to add "noqa" comments. This issue was addressed in recent versions, all we have to do is bump the "hacking" dependency, which currently enforces older flake8 releases. PyCQA/pycodestyle#1148
1 parent 1c82dbd commit 8901256

3 files changed

Lines changed: 7 additions & 7 deletions

File tree

coriolisclient/tests/cli/test_deployments.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ def test_get_parser(self):
219219
'--user-script-instance', instance_script])
220220
self.assertEqual(
221221
('transfer_id', True, False, True,
222-
processed_global_scripts, processed_instance_scripts),
222+
processed_global_scripts, processed_instance_scripts),
223223
(args.transfer, args.force, args.clone_disks,
224224
args.skip_os_morphing, args.global_scripts,
225225
args.instance_scripts))

coriolisclient/tests/cli/test_utils.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -283,14 +283,14 @@ def test_comma_separated_kv_to_dict_invalid(self, params):
283283
"global_scripts": None,
284284
# Too many parameters.
285285
"instance_scripts": [
286-
f"linux={_user_script_path},windows={_user_script_path}"], # noqa
286+
f"linux={_user_script_path},windows={_user_script_path}"],
287287
"expected_result": None
288288
},
289289
{
290290
"global_scripts": None,
291291
# Invalid phase.
292292
"instance_scripts": [
293-
f"linux={_user_script_path},phase=invalid-phase"], # noqa
293+
f"linux={_user_script_path},phase=invalid-phase"],
294294
"expected_result": None
295295
}
296296
)
@@ -326,13 +326,13 @@ def test_compose_user_scripts_from_file(self):
326326
script_path = os.path.join(script_path, 'data/user_scripts.yml')
327327
global_scripts = [
328328
f"linux={script_path}",
329-
f"windows={script_path},phase=osmorphing_pre_os_mount", # noqa
330-
f"windows={script_path},phase=osmorphing_post_os_mount", # noqa
329+
f"windows={script_path},phase=osmorphing_pre_os_mount",
330+
f"windows={script_path},phase=osmorphing_post_os_mount",
331331
]
332332
instance_scripts = [
333333
f"instance0={script_path}",
334334
f"instance1={script_path}",
335-
f"instance1={script_path},phase=osmorphing_pre_os_mount", # noqa
335+
f"instance1={script_path},phase=osmorphing_pre_os_mount",
336336
]
337337

338338
# We could've provided the dicts directly but we'll exercise

test-requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
# of appearance. Changing the order has an impact on the overall integration
33
# process, which may cause wedges in the gate later.
44

5-
hacking>=6.0.1,<=6.0.1 # Apache-2.0
5+
hacking>=7.0.0,<7.1.0 # Apache-2.0
66
coverage!=4.4,>=4.0 # Apache-2.0
77
ddt>=1.2.1 # MIT
88
oslotest>=3.8.0 # Apache-2.0

0 commit comments

Comments
 (0)