Fix include_task_info for transfer show --show-instances-data

The transfer's `info` is only returned with
`include_task_info=true`, which the CLI never sent,
so `--show-instances-data` failed with "ERROR: info".
Add an `include_task_info` flag to
TransferManager.get and set it when the option is passed.

Author: mihaelabalutoiu

coriolisclient/cli/transfers.py

@@ -308,7 +308,8 @@ def get_parser(self, prog_name):
 
     def take_action(self, args):
         coriolis = self.app.client_manager.coriolis
-        transfer = coriolis.transfers.get(args.id)
+        transfer = coriolis.transfers.get(
+            args.id, include_task_info=args.show_instances_data)
         executions = coriolis.transfer_executions.list(
             args.id,
             limit=TRANSFER_SHOW_EXECUTIONS_LIMIT,

coriolisclient/tests/cli/test_transfers.py

@@ -340,7 +340,9 @@ def test_take_action(self, mock_formatter_class):
             mock_formatter.get_formatted_entity.return_value,
             result
         )
-        mock_get.assert_called_once_with(mock.sentinel.id)
+        mock_get.assert_called_once_with(
+            mock.sentinel.id,
+            include_task_info=mock.sentinel.show_instances_data)
         mock_list.assert_called_once_with(
             mock.sentinel.id,
             limit=transfers.TRANSFER_SHOW_EXECUTIONS_LIMIT,

coriolisclient/tests/v1/test_transfers.py

@@ -135,6 +135,19 @@ def test_get(self, mock_get):
         mock_get.assert_called_once_with(
             "/transfers/%s" % mock.sentinel.transfer, "transfer")
 
+    @mock.patch.object(transfers.TransferManager, "_get")
+    def test_get_with_task_info(self, mock_get):
+        result = self.transfer.get(
+            mock.sentinel.transfer, include_task_info=True)
+
+        self.assertEqual(
+            mock_get.return_value,
+            result
+        )
+        mock_get.assert_called_once_with(
+            "/transfers/%s?include_task_info=true" % mock.sentinel.transfer,
+            "transfer")
+
     @mock.patch.object(transfers.TransferManager, "_post")
     def test_create(self, mock_post):
         expected_data = {

coriolisclient/v1/transfers.py

@@ -69,8 +69,11 @@ def list(self, detail=False, marker=None, limit=None,
             path = "%s/detail" % path
         return self._list(path, 'transfers', query=query)
 
-    def get(self, transfer):
-        return self._get('/transfers/%s' % base.getid(transfer), 'transfer')
+    def get(self, transfer, include_task_info=False):
+        url = '/transfers/%s' % base.getid(transfer)
+        if include_task_info:
+            url += '?include_task_info=true'
+        return self._get(url, 'transfer')
 
     def create(self, origin_endpoint_id, destination_endpoint_id,
                source_environment, destination_environment, instances,