Test#50
Conversation
There was a problem hiding this comment.
Pull request overview
Adds Python tooling to the pre-merge GitHub Actions workflow to support installing the Smart Tests CLI alongside the existing Java/Maven build.
Changes:
- Add
actions/setup-python@v5with Python 3.13 to the pre-merge workflow - Install
smart-tests-cliviapip
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| with: | ||
| python-version: '3.13' | ||
| - name: Install Smart Tests CLI | ||
| run: pip install --user --upgrade smart-tests-cli~=2.0 |
There was a problem hiding this comment.
pip install --user installs console scripts (e.g., smart-tests) into the user bin dir (typically ~/.local/bin), which may not be on PATH for subsequent steps. To avoid flaky “command not found” issues, either install without --user (using the toolcache Python from actions/setup-python) and run via python -m pip ..., or explicitly add the user bin directory to GITHUB_PATH before invoking the CLI.
| run: pip install --user --upgrade smart-tests-cli~=2.0 | |
| run: python -m pip install --upgrade smart-tests-cli~=2.0 |
| - name: Install Smart Tests CLI | ||
| run: pip install --user --upgrade smart-tests-cli~=2.0 |
There was a problem hiding this comment.
The workflow installs smart-tests-cli but never invokes smart-tests (only mvn compile/mvn test). If the CLI isn’t needed yet, consider removing this install step to keep CI faster; if it is needed, consider adding the intended smart-tests ... step(s) in the same PR so the dependency is justified.
| - name: Install Smart Tests CLI | |
| run: pip install --user --upgrade smart-tests-cli~=2.0 |
No description provided.