Skip to content

Commit c57b160

Browse files
Fixed the Comment parsing errors when the type field is absent
1 parent e74ad33 commit c57b160

2 files changed

Lines changed: 10 additions & 1 deletion

File tree

src/main/java/org/zendesk/client/v2/model/Comment.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import static com.fasterxml.jackson.annotation.JsonTypeInfo.As.EXTERNAL_PROPERTY;
44
import static com.fasterxml.jackson.annotation.JsonTypeInfo.Id.NAME;
55

6+
import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
67
import com.fasterxml.jackson.annotation.JsonProperty;
78
import com.fasterxml.jackson.annotation.JsonSubTypes;
89
import com.fasterxml.jackson.annotation.JsonTypeInfo;
@@ -16,12 +17,18 @@
1617
* @author stephenc
1718
* @since 09/04/2013 15:09
1819
*/
19-
@JsonTypeInfo(use = NAME, include = EXTERNAL_PROPERTY, property = "type", visible = true)
20+
@JsonTypeInfo(
21+
use = NAME,
22+
include = EXTERNAL_PROPERTY,
23+
property = "type",
24+
defaultImpl = Comment.class,
25+
visible = true)
2026
@JsonSubTypes({
2127
@JsonSubTypes.Type(value = Comment.class, name = "Comment"),
2228
@JsonSubTypes.Type(value = VoiceComment.class, name = "VoiceComment"),
2329
@JsonSubTypes.Type(value = VoiceComment.class, name = "TpeVoiceComment")
2430
})
31+
@JsonIgnoreProperties(ignoreUnknown = true)
2532
public class Comment implements Serializable {
2633

2734
private static final long serialVersionUID = 1L;

src/main/java/org/zendesk/client/v2/model/comments/VoiceComment.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
11
package org.zendesk.client.v2.model.comments;
22

3+
import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
34
import com.fasterxml.jackson.annotation.JsonProperty;
45
import org.zendesk.client.v2.model.Comment;
56

7+
@JsonIgnoreProperties(ignoreUnknown = true)
68
public class VoiceComment extends Comment {
79

810
private VoiceCommentData data;

0 commit comments

Comments
 (0)