fix: use BASE_PATH for WebSocket URL in subpath deployments#5
Open
rjmayott wants to merge 1 commit intocloudcli-ai:mainfrom
Open
fix: use BASE_PATH for WebSocket URL in subpath deployments#5rjmayott wants to merge 1 commit intocloudcli-ai:mainfrom
rjmayott wants to merge 1 commit intocloudcli-ai:mainfrom
Conversation
When CloudCLI is served from a subpath (e.g. /s/myproject/), the plugin-ws WebSocket URL needs the base path prefix. Reads window.__CLOUDCLI_BASE_PATH__ which CloudCLI injects at runtime. Without this, the WebSocket connects to /plugin-ws/web-terminal instead of /s/myproject/plugin-ws/web-terminal and fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When CloudCLI is served from a subpath (e.g.
/s/myproject/) via a reverse proxy, the terminal plugin's WebSocket URL is missing the base path prefix. It connects to/plugin-ws/web-terminalinstead of/s/myproject/plugin-ws/web-terminal, causing the connection to fail.Fix
Read
window.__CLOUDCLI_BASE_PATH__(injected by CloudCLI's server at runtime) and prefix the WebSocket URL. Falls back to empty string when not set, so behavior is unchanged for root deployments.Related: siteboon/claudecodeui#687 (adds BASE_PATH support to CloudCLI)
Test plan
/s/personal/behind reverse proxy/