What is happening with this repo?

[phpfui]

So I have to add a Constant Contact API to my website. Looks like the official CC repo has not been updated in 6 years and it is full of PR and open issues, and is V2 to boot.

Looks like this is the only V3 repo out there that is not some sort of Laravel or other custom framework specific library (have no idea why people do that, but what do you expect from PHP developers?)

In this repo's current form, it can't be used, as it has a minimum stability of dev. I also notice you have a lot of useless comments and a mix of use statements and fully qualified names. I personally don't use "use" statements, as they are just another level of indirection and slow PHP down at run time.

Anyway, this looks likes the beginning of a good library, and I love that it is 7.3. I would be happy to help out. Here is what I see needs to be done:

Readme.md
PHP CS Fixer support
PHPUnit Tests
Removal of useless comments (eg @param string $varName when defined by method parameters)
Removal of use statements to use FQN everywhere (faster execution and less ambiguous)
Full docs at PHPFUI, oh, already did that.

Let me know if you want some help.

Bruce

[cloudcogsio]

This was developed for a personal use case.

Feel free to fork, modify and submit PRs.

Some comments you may deem useless are IDE related and provide hints during development. These are non issues and can easily be improved for a release version. As you noted, it's still a dev repo.

[phpfui]

So I took a closer look at the Constant Contact API and I saw that they had a YAML schema. So I wrote a program to generate classes and definitions. I am still debugging the connection and logic, but the basic structure is set. You can check the class structure out here Constant Contact V3

[phpfui]

I published my V3 library. Completely based on the schema and auto updates to any changes to the schema on a nightly basis. Also added a next() method to get more results if a response is paginated. Works well.

Constant Contact V3 API