chore: update smurf shared workflows for Docker, Helm, and Terraform, and update the documentation.#405
Merged
clouddrove-ci merged 3 commits intoJul 15, 2026
Conversation
…d update document
anket-satbhai
requested review from
a team,
anmolnagpal and
clouddrove-ci
as code owners
July 10, 2026 13:14
dverma-cd
reviewed
Jul 10, 2026
| AWS_SESSION_TOKEN: | ||
| required: false | ||
| description: AWS Session Token for direct authentication | ||
| BUILD_ROLE: |
Member
There was a problem hiding this comment.
can we make it AWS_BUILD_ROLE
dverma-cd
reviewed
Jul 10, 2026
| smurf sdkr build ${{ inputs.docker_image_name }}:${{ inputs.docker_image_tag }} -f ${{ | ||
| inputs.dockerfile_path }} --platform ${{ inputs.docker_build_platform }} | ||
| smurf sdkr build ${{ inputs.docker_image_name }}:${{ inputs.docker_image_tag }} \ | ||
| -f ${{ inputs.dockerfile_path }} \ |
Member
There was a problem hiding this comment.
Please corss check indentation here
dverma-cd
reviewed
Jul 10, 2026
|
|
||
| - uses: webfactory/ssh-agent@v0.10.0 | ||
| if: ${{ inputs.git_ssh_key_setup == true }} | ||
| if: ${{ inputs.git_ssh_key_setup }} |
Member
There was a problem hiding this comment.
make sure here , you are removing conditions , its not effecting any resource default creation
hahirwar-cd
approved these changes
Jul 10, 2026
28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds full documentation and caller workflow examples for the Smurf reusable workflows (
docker-smurf,helm-smurf,tf-smurf), and updates the shared workflows to match the tested shared + caller pattern.Documentation
docs/docker-smurf.md— Architecture, inputs/secrets reference,docker_registry_urlnaming, and caller examples for AWS ECR, Docker Hub, GCP, and Azure ACRdocs/helm-smurf.md— Lint/deploy/rollback flow, multi-cloud callers (EKS, GKE, AKS), and deploy vs rollback dispatch patterndocs/tf-smurf.md— Plan/apply/destroy flow,run_create/run_destroymatrix, and callers for AWS, Azure, GCP, and DigitalOceanType of Change
Workflow changes
Docker (
docker-smurf.yml)v1.1.5BUILD_ROLE,DOCKER_USERNAME, andDOCKER_PASSWORDsecretsdocker-image) and build command formattingdockerfile_pathas repo-root-relative pathHelm (
helm-smurf.yml)helm-lint,helm-deploy, andhelm-rollbackjobshelm_enableandhelm_rollback_enablehelm_extra_argssecretTerraform (
tf-smurf.yml)destroyinput withrun_createandrun_destroyARM_*credential export and orphaned resource group import before destroyplan_only,plan_out, andauto_approveinputsv1.1.5Workflow Category
tf-*)cf-*)docker-*)helm-*)pr-*)security-*)release-*)notify-*)aws-*)gcp-*)yl-*)Checklist
Testing
https://github.com/clouddrove-sandbox/smurf-workflows