Conversation
|
|
||
| impl MlDsaPublicKey { | ||
| /// Parses a public key from its serialized form. | ||
| pub fn from_bytes(algorithm: Algorithm, bytes: &[u8]) -> Result<Self, ErrorStack> { |
There was a problem hiding this comment.
Maybe there should be a to_bytes() counterpart?
cjpatton
left a comment
cjpatton
left a comment
There was a problem hiding this comment.
Looks good, one cosmetic thing for consistency with mlkem
See recent comments from cloudflare/boring#497
| MlDsa87(Box<ffi::MLDSA87_private_key>), | ||
| } | ||
|
|
||
| impl MlDsaPrivateKey { |
There was a problem hiding this comment.
It would be very useful to have a public_key() function as well.
There was a problem hiding this comment.
That's from RustCrypto's implementation. Boring's version is a bit more involved. I'll leave it for later.
kornelski
force-pushed
the
mldsa
branch
3 times, most recently
from
f743a23 to
91a2c70
Compare
|
Is this still needed now that we've pulled in BoringSSL's ML-DSA support? #509 |
Perhaps I'm missing something, but I assume without this MR you would still need to use the FFI to generate ML-DSA signatures? This seems like a pretty nice API just for generating standalone signatures |
6 participants
No description provided.