[Artifacts] Improve get-started guide for Workers#30352
Open
dinasaur404 wants to merge 3 commits intoproductionfrom
Open
[Artifacts] Improve get-started guide for Workers#30352dinasaur404 wants to merge 3 commits intoproductionfrom
dinasaur404 wants to merge 3 commits intoproductionfrom
Conversation
dinasaur404
requested review from
a team,
elithrar,
mattzcarey and
whoiskatrin
as code owners
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
- Add try/catch error handling for repo creation with 409 conflict response - Clarify returned values and their purposes - Add bullet points explaining name and token fields - Add step to switch to Worker directory before deploy - Improve explanations throughout the guide
dinasaur404
force-pushed
the
artifacts-docs
branch
from
15696e5 to
964d7bb
Compare
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
|
Preview URL: https://c537604e.preview.developers.cloudflare.com Files with changes (up to 15)
|
elithrar
reviewed
Apr 27, 2026
| } catch (err) { | ||
| // Return an error if the repo name is already taken. | ||
| const message = err instanceof Error ? err.message : String(err); | ||
| const status = message.includes("already exists") ? 409 : 500; |
Collaborator
There was a problem hiding this comment.
@dmmulroy this should be a typed error for a 409 (exists) vs. generic server error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves the Artifacts get-started guide for Workers with clearer explanations and better error handling.
Changes: