fix: add missing setup steps to bonk-auto-triage#30765
Conversation
mvvmm
requested review from
a team,
MohamedH1998,
ahaywood,
colbywhite and
kodster28
as code owners
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
ask-bonk
Bot
added
engineering
![ask-bonk[bot]](https://avatars.githubusercontent.com/in/2454580?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Triage Summary
This PR fixes the bonk-auto-triage GitHub Actions workflow by adding the missing repository checkout and Node.js toolchain setup steps. Without these steps, the ask-bonk action fails during its Configure Git phase with fatal: not a git repository.
What changed:
- Adds
actions/checkout,pnpm/action-setup,actions/setup-node,actions/cache, andpnpm install --frozen-lockfilesteps to thebonk-auto-triagejob - Mirrors the exact setup already present in the
bonkjob, ensuring consistency across both jobs - Maintains the more restrictive
contents: readpermission (correct, since auto-triage does not push commits)
Labels applied: engineering, bug
Flagged issue:
- The comment block in the
bonk-auto-triagejob claims the workflow does not check out code, but this PR explicitly adds a checkout step. This comment should be updated to avoid confusing future maintainers (see inline comment).
Overall, this is a clean, targeted fix. No blockers.
|
Triage completed for PR #30765. SummaryThis PR fixes the Labels Applied
Issue FlaggedI left an inline review comment on the new VerdictNo blockers. The change is a clean, targeted fix with correct pinned action versions and appropriate permissions ( |
mvvmm
changed the title
mvvmm
changed the title
|
/bonk please re-review |
mvvmm
changed the title
|
@mvvmm Bonk workflow was cancelled. View workflow run · To retry, trigger Bonk again. |
|
/bonk please review |
|
Preview URL: https://138ca265.preview.developers.cloudflare.com |
* fix: add checkout step to bonk-auto-triage job * fix: add full setup steps to bonk-auto-triage to match bonk job * fix: remove unnecessary pnpm/node_modules setup from bonk jobs * fix: restore pnpm/node_modules setup to both bonk jobs * fix: use pull_request_target for auto-triage, checkout base ref, update comment * fix: revert to pull_request event, remove pull_request_target comment * chore: rename bonk-auto-triage to bonk-auto-review * fix: handle missing GH_ORG_TOKEN gracefully in check-codeowner
5 participants
Fixes the
bonk-auto-triagejob introduced in #30743:bonkjob — the job was failing withfatal: not a git repository.