Add asset_name to RulesetRuleActionParameters#4312
Merged
vaishakdinesh merged 1 commit intoMay 20, 2026
Conversation
Adds the asset_name field to RulesetRuleActionParameters so that http_custom_errors phase rules using the serve_error action correctly round-trip the asset_name attribute returned by the Cloudflare API. Without this field, the typed struct silently drops asset_name during JSON decode, causing downstream tools (e.g. cf-terraforming) to emit configurations that diverge from the live ruleset and produce drift on subsequent applies.
vaishakdinesh
approved these changes
May 20, 2026
musa-cf
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the asset_name field to RulesetRuleActionParameters so that http_custom_errors phase rules using the serve_error action correctly round-trip the asset_name attribute returned by the Cloudflare API.
Without this field, the typed struct silently drops asset_name during JSON decode, causing downstream tools (e.g. cf-terraforming) to emit configurations that diverge from the live ruleset and produce drift on subsequent applies.
Changes being requested
Additional context & links