update linting rules and adjust code accordingly#208
Merged
Conversation
Eslint's `preserve-caught-error` check is useful. Let's keep it on and adjust the locations where it is finding hits.
In most cases, the `@typescript-eslint/explicit-module-boundary-types` is useful and should be followed. Not using it for `makeMockCtx`, since the return value is constructed dynamically.
commit: |
gabivlj
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two linting rules were disabled that can now be re-enabled:
preserve-caught-error- ensures we don't throw away useful information when throwing an exception@typescript-eslint/explicit-module-boundary-types- ensures public methods and exported functions declare return types (disabled formakeMockCtxsince the returned mock is dynamically created)