fix(Resources): URLs should not contain trailing slashes

APIv4 URLs do not have trailing slashes. Unfortunately, `url-join`
pushes arguments onto an array and joins them with '/' without first
ensuring removing empty segments.

Since we only ever join two segments ourselves, and we control both
segments, we don't need this dependency or it's normalization.

Author: terinjokes

lib/Client.js

@@ -1,6 +1,5 @@
 'use strict';
 var prototypal = require('es-class');
-var join = require('url-join');
 var pkg = require('../package.json');
 var Getter = require('./Getter');
 
@@ -32,7 +31,7 @@ module.exports = prototypal({
     this.getter = new Getter(options);
   },
   request: function (requestMethod, requestPath, data, opts) {
-    var uri = join('https://api.cloudflare.com/client/v4/', requestPath);
+    var uri = 'https://api.cloudflare.com/client/v4/' + requestPath;
 
     var options = {
       json: true,

lib/Resource.js

@@ -1,6 +1,5 @@
 'use strict';
 var prototypal = require('es-class');
-var join = require('url-join');
 var method = require('./method');
 
 var BASIC_METHODS = {
@@ -45,7 +44,7 @@ module.exports = prototypal({
     }
   },
   createFullPath: function (methodPath) {
-    return join(this.path, methodPath);
+    return (methodPath && [this.path, methodPath].join('/')) || this.path;
   },
   path: '',
   hasBrokenPatch: false

package-lock.json

@@ -11,7 +11,6 @@
     "es-class": "^2.1.1",
     "got": "^6.3.0",
     "object-assign": "^4.1.0",
-    "url-join": "^1.1.0",
     "url-pattern": "^1.0.3"
   },
   "devDependencies": {

package.json

@@ -37,7 +37,7 @@ describe('Resource', function () {
 
       var path = subject.createFullPath();
 
-      assert.equal(path, '/');
+      assert.equal(path, '');
     });
 
     it('joins method path with resource path', function () {