fix(partysocket): avoid module-scope random default#397
Open
agcty wants to merge 1 commit intocloudflare:mainfrom
Open
fix(partysocket): avoid module-scope random default#397agcty wants to merge 1 commit intocloudflare:mainfrom
agcty wants to merge 1 commit intocloudflare:mainfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid calling
Math.random()whilepartysocket/wsis imported by replacing the module-scope randomized defaultminReconnectionDelaywith the deterministic midpoint of the previous range.This keeps the public
minReconnectionDelayoption unchanged, while making the default safe for Worker/server runtimes that reject random-value generation during module evaluation.Why
Cloudflare Workers disallow random value generation in global scope. In SSR/RSC environments running inside Workerd, importing client component trees can evaluate
partysocket/wson the server, which currently trips that restriction via the top-level default object.Tests
npx oxfmt --check packages/partysocket/src/ws.ts packages/partysocket/src/tests/module-scope.test.tsnpm run check:test -w partysocket -- src/tests/module-scope.test.tsnpm run check:test -w partysocketnpm run build -w partysocket