Skip to content

fix(partysocket): avoid module-scope random default#397

Open
agcty wants to merge 1 commit intocloudflare:mainfrom
agcty:fix/partysocket-worker-global-random
Open

fix(partysocket): avoid module-scope random default#397
agcty wants to merge 1 commit intocloudflare:mainfrom
agcty:fix/partysocket-worker-global-random

Conversation

@agcty
Copy link
Copy Markdown

@agcty agcty commented May 3, 2026

Summary

Avoid calling Math.random() while partysocket/ws is imported by replacing the module-scope randomized default minReconnectionDelay with the deterministic midpoint of the previous range.

This keeps the public minReconnectionDelay option unchanged, while making the default safe for Worker/server runtimes that reject random-value generation during module evaluation.

Why

Cloudflare Workers disallow random value generation in global scope. In SSR/RSC environments running inside Workerd, importing client component trees can evaluate partysocket/ws on the server, which currently trips that restriction via the top-level default object.

Tests

  • npx oxfmt --check packages/partysocket/src/ws.ts packages/partysocket/src/tests/module-scope.test.ts
  • npm run check:test -w partysocket -- src/tests/module-scope.test.ts
  • npm run check:test -w partysocket
  • npm run build -w partysocket

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 3, 2026

⚠️ No Changeset found

Latest commit: 460765d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant