remove vendored BoringSSL option (fix)#2134
Closed
kornelski wants to merge 3 commits into
Closed
Conversation
kornelski
force-pushed
the
no-boringssl-vendored
branch
4 times, most recently
from
4a5ed4b to
737b951
Compare
This fails when building with the boring crate. FWIW it's also a "tier 2" platform for Rust.
We should just use the one provided via boring/boring-sys crates. It should still be possible to build a different BoringSSL version through the facilities provided by those crates.
kornelski
force-pushed
the
no-boringssl-vendored
branch
2 times, most recently
from
83e252c to
4495666
Compare
kornelski
force-pushed
the
no-boringssl-vendored
branch
from
4495666 to
d2c441a
Compare
Contributor
Author
|
Cross-building works, but the test fails off by 1? https://github.com/cloudflare/quiche/actions/runs/17243868980/job/48928287802?pr=2134#step:5:1539 |
Member
|
Awesome, thank you @kornelski! I opened #2142 to isolate the cross-build change so it's easier to debug the build failure. I also added some minor tweaks to restore the armhf build as well since I originally removed it to fix the same errors we were getting with arm64 before your changes, so closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully makes #2080 build