Skip to content

qlog-dancer: improve conversion speed and disk usage and fix garbled output on Windows #2377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
csujedihy wants to merge 2 commits into
base: master
Choose a base branch
from
Open

qlog-dancer: improve conversion speed and disk usage and fix garbled output on Windows #2377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dea326c
Render the event table without tabled and uses ASCII style
csujedihy Mar 1, 2026
014e4c3
Preserve 3 digits on time
csujedihy Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 24 additions & 3 deletions qlog-dancer/src/reports/events.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,9 +233,9 @@ fn http_frame_to_string(frame: &Http3Frame) -> String {
s
}

pub fn sqlog_event_list(
fn build_event_list(
events: &[qlog::reader::Event],
) -> tabled::builder::Builder {
) -> Vec<PrintableEvent> {
let mut pp = vec![];

for event in events {
Expand Down Expand Up @@ -457,5 +457,26 @@ pub fn sqlog_event_list(
}
}

Table::builder(pp)
pp
}

pub fn sqlog_event_list(
events: &[qlog::reader::Event],
) -> tabled::builder::Builder {
Table::builder(build_event_list(events))
}

pub fn print_sqlog_events(events: &[qlog::reader::Event]) {
let pp = build_event_list(events);
println!("Qlog events");
println!(
"{:>12} | {:<10} | {:<25} | {}",
"time", "category", "Type", "details"
);
for p in &pp {
println!(
"{:>12.3} | {:<10} | {:<25} | {}",
p.time, p.category, p.ty, p.details
);
}
}
8 changes: 2 additions & 6 deletions qlog-dancer/src/reports/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@

//! Reporting (tables etc.)

use events::sqlog_event_list;
use tabled::settings::Style;
use events::print_sqlog_events;

use crate::config::AppConfig;
use crate::LogFileParseResult;
Expand Down Expand Up @@ -55,10 +54,7 @@ pub fn report(log_file: &LogFileParseResult, config: &AppConfig) {
match &data.raw {
crate::RawLogEvents::QlogJson { events: _ } => todo!(),
crate::RawLogEvents::QlogJsonSeq { events } => {
let mut table = sqlog_event_list(events).build();
table.with(Style::sharp());
println!("Qlog events");
println!("{}", table);
print_sqlog_events(events);
},
crate::RawLogEvents::Netlog => todo!(),
}
Expand Down
2 changes: 2 additions & 0 deletions qlog-dancer/src/reports/text.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,8 @@ pub fn request_timing_table(
let style = Style::empty().vertical(',');

table.with(style);
} else {
table.with(Style::ascii());
}

Some(table)
Expand Down