Skip to content

Addressing nonce mismatch and cryptofail with quiche/boring #2412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
somethingcorrosive wants to merge 6 commits into
base: master
Choose a base branch
from
+4 −6
Open

Addressing nonce mismatch and cryptofail with quiche/boring #2412

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fcc2c69
Addressing noncemismatch and cryptofail with quiche/boring
somethingcorrosive Mar 21, 2026
b3d4e7f
Merge branch 'master' into something/cryptofail_nonce_mismatch_quiche…
somethingcorrosive Mar 27, 2026
8021958
Merge branch 'master' into something/cryptofail_nonce_mismatch_quiche…
somethingcorrosive Mar 30, 2026
1001ff7
Merge branch 'master' into something/cryptofail_nonce_mismatch_quiche…
somethingcorrosive May 20, 2026
de057fb
Merge branch 'master' into something/cryptofail_nonce_mismatch_quiche…
somethingcorrosive May 20, 2026
eb75c68
Merge branch 'master' into something/cryptofail_nonce_mismatch_quiche…
somethingcorrosive May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions quiche/src/crypto/boringssl.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ pub(crate) struct AES_KEY {
impl Algorithm {
fn get_evp_aead(self) -> *const EVP_AEAD {
match self {
Algorithm::AES128_GCM => unsafe { EVP_aead_aes_128_gcm_tls13() },
Algorithm::AES256_GCM => unsafe { EVP_aead_aes_256_gcm_tls13() },
Algorithm::AES128_GCM => unsafe { EVP_aead_aes_128_gcm() },
Algorithm::AES256_GCM => unsafe { EVP_aead_aes_256_gcm() },
Algorithm::ChaCha20_Poly1305 => unsafe {
EVP_aead_chacha20_poly1305()
},
Expand Down Expand Up @@ -320,10 +320,8 @@ pub(crate) fn hkdf_expand(
}

extern "C" {
fn EVP_aead_aes_128_gcm_tls13() -> *const EVP_AEAD;

fn EVP_aead_aes_256_gcm_tls13() -> *const EVP_AEAD;

fn EVP_aead_aes_128_gcm() -> *const EVP_AEAD;
fn EVP_aead_aes_256_gcm() -> *const EVP_AEAD;
fn EVP_aead_chacha20_poly1305() -> *const EVP_AEAD;

// HKDF
Expand Down