tokio-quiche: drain coalesced QUIC packets on recv#2443
Closed
babasha wants to merge 2 commits into
Closed
Conversation
quiche::Connection::recv only processes one QUIC packet per call, but a single UDP datagram can contain several coalesced packets (a server commonly coalesces Initial + Handshake, and loopback MTU=65536 makes this common in local tests). The existing call sites in ClientConnector and IoWorker invoked recv once per buffer, so any packet coalesced after the first was silently discarded -- handshakes stall waiting for a Handshake-level frame that was already delivered. Introduce a recv_coalesced helper at each call site that loops over conn.recv until it returns Done, advancing the buffer by the number of bytes quiche consumed.
Record debug information when recv_coalesced encounters an error. Previously the code silently broke on any Err; now it logs the error and the source (recv_info.from) before breaking to aid debugging of client connector receive failures.
Contributor
|
quiche's |
Contributor
Some evidence of it being handled correctly: If you look at the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
quiche::Connection::recv only processes one QUIC packet per call, but a single UDP datagram can contain several coalesced packets (a server commonly coalesces Initial + Handshake, and loopback MTU=65536 makes this common in local tests). The existing call sites in ClientConnector and IoWorker invoked recv once per buffer, so any packet coalesced after the first was silently discarded -- handshakes stall waiting for a Handshake-level frame that was already delivered.
Introduce a recv_coalesced helper at each call site that loops over conn.recv until it returns Done, advancing the buffer by the number of bytes quiche consumed.