Only poll ApplicationOverQuic wait_for_data after handshake is ready or we're in early data#2480
Open
MaxF12 wants to merge 1 commit into
Open
Only poll ApplicationOverQuic wait_for_data after handshake is ready or we're in early data#2480MaxF12 wants to merge 1 commit into
MaxF12 wants to merge 1 commit into
Conversation
MaxF12
changed the title
| if quic_application.should_act() { | ||
| let connection_ready = qconn.is_established() || qconn.is_in_early_data(); | ||
|
|
||
| if connection_ready && quic_application.should_act() { |
Contributor
There was a problem hiding this comment.
This change makes some sense to me. What tests could we add for this case to ensure we don't regress?
Prevent eager application wakeups from preempting handshake progress before the connection is established. Keep handshake driving in the quiche path until 1-RTT or early-data readiness.\n\nAdd a regression test using an eager application and asynchronous certificate callback to ensure the handshake reaches on_conn_established().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tokio-quiche can poll wait_for_data() too early during connection setup. For apps that always report should_act()==true an overly eager wait_for_data() could preempt the handshake which might stall the handshake itself. Now wait_for_data() can only be polled if the 1-RTT handshake is either completed or we are in early-data