-
Notifications
You must be signed in to change notification settings - Fork 367
fix(dev): preserve public asset conditional requests #2711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Boyeep
wants to merge
42
commits into
cloudflare:main
Choose a base branch
from
Boyeep:feat/static-byte-ranges
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
d2e8e57
fix(server): use weak comparison for If-None-Match
Boyeep e527192
feat(server): support static asset byte ranges
Boyeep 4db2e69
fix(server): validate If-Range HTTP dates
Boyeep 932bfc8
chore: retrigger CI
Boyeep a61586f
chore: retrigger CI
Boyeep 08a4f00
chore: retrigger flaky E2E
Boyeep 9ce704a
fix(server): validate conditional static requests
james-elicx f11c2f9
fix(server): tighten entity-tag parsing
james-elicx 1c0b44e
test(server): document entity-tag comma behavior
james-elicx 1e2d403
fix(dev): weak-match public asset etags
james-elicx 233099b
fix(dev): normalize public etag lookup paths
james-elicx 7f52c55
fix(server): preserve byte range wire semantics
james-elicx 0d30107
fix(server): preserve partial response validators
james-elicx 4c95813
fix(dev): canonicalize conditional public assets
james-elicx ea7dbd5
fix(server): resolve obsolete HTTP date years
james-elicx 510f8e0
fix(dev): honor Vite public file identity
james-elicx 1b3c835
fix(dev): mirror Vite public filesystem semantics
james-elicx b395c75
fix(dev): refresh public filesystem capabilities
james-elicx b4dfe41
fix(dev): verify public path aliases
james-elicx 9e13f24
refactor(server): share strict HTTP date parsing
james-elicx ecc9fad
fix(dev): index verified public request aliases
james-elicx 0db6645
fix(dev): compose verified public path aliases
james-elicx 99babf4
fix(dev): resolve Unicode public path classes
james-elicx bdb00b8
fix(dev): use Unicode simple case matching
james-elicx a8df551
fix(dev): match Unicode expansion tokens
james-elicx 29d95eb
Merge remote-tracking branch 'origin/main' into codex/pr2710-ready
james-elicx 35e80a8
Merge PR #2710 into static byte ranges
james-elicx ae2ad77
Merge latest main into static byte ranges
james-elicx d7c238e
Merge final PR #2710 head into static byte ranges
james-elicx a8a36f3
fix(dev): keep public ETag trie internal
james-elicx 4175bc8
fix(dev): keep public path node private
james-elicx aee5021
Merge remote-tracking branch 'origin/main' into codex/pr2710-ready
james-elicx 14ada51
Merge remote-tracking branch 'origin/main' into codex/pr2710-ready
james-elicx 7cdf5d3
Merge updated PR #2710 head into static byte ranges
james-elicx 1eb997d
fix(dev): resolve public-root symlink redirects
james-elicx 26f315d
fix(dev): resolve public-root symlink redirects
james-elicx f076a56
Merge commit '26f315db8f0c39a493fcee7150eb7a492eb5b180' into codex/pr…
james-elicx 220fffc
Merge remote-tracking branch 'origin/main' into codex/pr2711-owner
james-elicx a256627
fix(dev): fail closed on conflicting public redirects
james-elicx 36c5f76
Merge remote-tracking branch 'origin/main' into codex/pr2711-owner
james-elicx ec3ec0b
Merge remote-tracking branch 'origin/main' into codex/pr2711-owner
james-elicx 454c1c1
Merge remote-tracking branch 'origin/main' into agent/sync-pr2711
Boyeep File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When an application configures Vite's
basedirectly (for example,base: "/docs/") without setting Next'sbasePath, this passes an empty base path to the lookup. A request for/docs/asset.jstherefore misses the indexed/asset.js; Vite subsequently strips/docsand serves the public file, but strong, list, or wildcardIf-None-Matchvalidators are left unnormalized and return 200 instead of 304. The Pages request handler already treatsserver.config.baseas the fallback routing base, so this middleware should derive the same resolved base path.Useful? React with 👍 / 👎.