fix(build): skip unhelpful precompressed variants#2712
Open
Boyeep wants to merge 1 commit into
Open
Conversation
commit: |
Contributor
Performance benchmarksCompared 0 improved · 0 regressed · 6 within ±1.5%
View detailed results and traces 🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Precompression previously wrote every encoding result regardless of size. High-entropy assets could therefore produce representations larger than the original, which the production server would still prefer during content negotiation. Reruns could also retain variants that were no longer useful.
Impact
Precompressed assets cannot increase transferred bytes, stale variants are cleaned up, and partially written variants are not exposed to the production server.
Validation
vp test run tests/precompress.test.ts tests/static-file-cache.test.tsvp check packages/vinext/src/build/precompress.ts packages/vinext/src/server/static-file-cache.ts tests/precompress.test.ts tests/static-file-cache.test.ts