Skip to content

test: give middleware auth guard assertion a CI-safe timeout #2720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
james-elicx merged 2 commits into from
Jul 27, 2026
Merged

test: give middleware auth guard assertion a CI-safe timeout #2720

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a977aea
test: give the unit project the integration timeout
NathanDrake2406 Jul 27, 2026
2abd661
test(middleware): scope auth guard timeout
james-elicx Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/middleware-matcher-auth.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ describe("valid middleware matcher auth guards", () => {

it("blocks every path selected by group and constrained-repeat matchers", async () => {
await assertAuthGuard(baseUrl);
});
}, 30_000);

@ask-bonk ask-bonk Bot Jul 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional: consider hoisting the 30_000 into a shared const (e.g. const DEV_ASSERT_TIMEOUT = 30_000;) reused by both this assertion and its beforeAll hook on line 143, so the two stay coupled if either is tuned later. Not blocking — the inline literal is fine and matches the existing style in this file.

});

describe("built Node production server", () => {
Expand Down
Loading