Enable require-description-when-disabling lint rule on shared packages (#13804)

Co-authored-by: ask-bonk[bot] <249159057+ask-bonk[bot]@users.noreply.github.com>

Author: dario-piotrowicz

.oxlintrc.jsonc

@@ -206,8 +206,6 @@
 				"packages/miniflare/**",
 				"packages/quick-edit-extension/**",
 				"packages/vitest-pool-workers/**",
-				"packages/workers-editor-shared/**",
-				"packages/workers-shared/**",
 				"packages/wrangler/**",
 			],
 			"rules": {

packages/workers-editor-shared/lib/ipc.ts

@@ -37,7 +37,7 @@ interface SetEntryPoint {
 }
 
 // Sent on load to request sources for inflating a stack trace
-// eslint-disable-next-line @typescript-eslint/no-empty-object-type
+// eslint-disable-next-line @typescript-eslint/no-empty-object-type -- interface used as a branded message type in the EditorMessage generic
 interface RequestSources {}
 
 export type WorkerLoadedMessage = EditorMessage<"WorkerLoaded", WorkerLoaded>;

packages/workers-editor-shared/lib/useRefreshableIframe.tsx

@@ -42,7 +42,7 @@ export function useRefreshableIframe(
 				second.removeEventListener("load", onLoadEvent);
 			};
 		}
-		// eslint-disable-next-line react-hooks/exhaustive-deps
+		// eslint-disable-next-line react-hooks/exhaustive-deps -- refs are stable across renders and should not trigger re-subscription
 	}, [onLoad]);
 
 	function listen() {
@@ -72,7 +72,7 @@ export function useRefreshableIframe(
 		if (src) {
 			setUrl(src);
 		}
-		// eslint-disable-next-line react-hooks/exhaustive-deps
+		// eslint-disable-next-line react-hooks/exhaustive-deps -- setUrl depends on mutable state that would cause infinite loops if included
 	}, [src]);
 	const isLoading = isLoadingContent;
 	return {

packages/workers-shared/asset-worker/src/assets-manifest.ts

@@ -96,11 +96,13 @@ function comparePathHashWithEntry(
 ) {
 	let pathHashOffset = HEADER_SIZE + entryIndex * ENTRY_SIZE + PATH_HASH_OFFSET;
 	for (let offset = 0; offset < PATH_HASH_SIZE; offset++, pathHashOffset++) {
-		// We know that both values could not be undefined
-		// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
-		const s = searchValue[offset]!;
-		// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
-		const e = manifest[pathHashOffset]!;
+		const s = searchValue[offset];
+		const e = manifest[pathHashOffset];
+		if (s === undefined || e === undefined) {
+			throw new TypeError(
+				`Unexpected undefined value at offset ${offset} during path hash comparison`
+			);
+		}
 		if (s < e) {
 			return -1;
 		}