Enable require-description-when-disabling lint rule on the vite plugin (#13741)

Co-authored-by: ask-bonk[bot] <249159057+ask-bonk[bot]@users.noreply.github.com>

Author: dario-piotrowicz

.oxlintrc.jsonc

@@ -205,7 +205,6 @@
 				"packages/local-explorer-ui/**",
 				"packages/miniflare/**",
 				"packages/quick-edit-extension/**",
-				"packages/vite-plugin-cloudflare/**",
 				"packages/vitest-pool-workers/**",
 				"packages/workers-editor-shared/**",
 				"packages/workers-shared/**",

packages/vite-plugin-cloudflare/e2e/fixtures/basic/src/main.tsx

@@ -3,9 +3,11 @@ import { createRoot } from "react-dom/client";
 import "./index.css";
 import App from "./App.tsx";
 
-// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
-createRoot(document.getElementById("root")!).render(
-	<StrictMode>
-		<App />
-	</StrictMode>
-);
+const rootElement = document.getElementById("root");
+if (rootElement) {
+	createRoot(rootElement).render(
+		<StrictMode>
+			<App />
+		</StrictMode>
+	);
+}

packages/vite-plugin-cloudflare/playground/containers/src/index.ts

@@ -10,7 +10,7 @@ export class Container extends DurableObject<Env> {
 
 	constructor(ctx: DurableObjectState, env: Env) {
 		super(ctx, env);
-		// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+		// eslint-disable-next-line @typescript-eslint/no-non-null-assertion -- we know that the container is defined on ctx
 		this.container = ctx.container!;
 	}
 

packages/vite-plugin-cloudflare/playground/external-workers/src/index.ts

@@ -81,7 +81,7 @@ export default {
 			const stream = await (
 				await fetch("https://thispersondoesnotexist.com/")
 			).body;
-			// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+			// eslint-disable-next-line @typescript-eslint/no-non-null-assertion -- we are sure that at this point there will be a stream
 			const transform = await env.IMAGES.input(stream!)
 				.transform({ blur: 250 })
 				.output({ format: "image/avif" });

packages/vite-plugin-cloudflare/playground/module-resolution/src/third-party/discord-api-types.ts

@@ -1,11 +1,14 @@
-import { RPCErrorCodes, Utils } from "discord-api-types/v10";
+import {
+	RPCErrorCodes,
+	Utils,
+	type APIButtonComponent,
+} from "discord-api-types/v10";
 
 // resolving discord-api-types/v10 (package which uses `require()`s without extensions
 // can be problematic, see: https://github.com/dario-piotrowicz/vitest-pool-workers-ext-repro)
 export default {
 	"(discord-api-types/v10) Utils.isLinkButton({})": Utils.isLinkButton(
-		// eslint-disable-next-line @typescript-eslint/no-explicit-any
-		{} as any
+		{} as APIButtonComponent
 	),
 	"(discord-api-types/v10) RPCErrorCodes.InvalidUser":
 		RPCErrorCodes.InvalidUser,

packages/vite-plugin-cloudflare/playground/node-compat/__tests__/worker-postgres/serve.ts

@@ -12,7 +12,7 @@ export async function preServe() {
 	mockPg = await createMockPostgresServer({
 		rows: [{ id: "21", name: "mock-row" }],
 	});
-	// eslint-disable-next-line turbo/no-undeclared-env-vars
+	// eslint-disable-next-line turbo/no-undeclared-env-vars -- internal to the test process: set here, read by vite.config.worker-postgres.ts in the same run
 	process.env.MOCK_PG_PORT = String(mockPg.port);
 }
 

packages/vite-plugin-cloudflare/playground/node-compat/vite.config.worker-postgres.ts

@@ -10,7 +10,7 @@ export default defineConfig({
 			configPath: "./worker-postgres/wrangler.jsonc",
 			// Inject the mock Postgres server port set by serve.ts preServe()
 			config: () => {
-				// eslint-disable-next-line turbo/no-undeclared-env-vars
+				// eslint-disable-next-line turbo/no-undeclared-env-vars -- internal to the test process: set by serve.ts preServe(), not an external input
 				const mockPgPort = process.env.MOCK_PG_PORT;
 				if (mockPgPort) {
 					return {

packages/vite-plugin-cloudflare/playground/node-compat/worker-process-populated-env/index.ts

@@ -8,9 +8,9 @@ export default {
 
 function testProcessBehaviour() {
 	try {
-		// eslint-disable-next-line turbo/no-undeclared-env-vars
+		// eslint-disable-next-line turbo/no-undeclared-env-vars -- Worker runtime code: populated via Worker bindings, not a Node.js process env var
 		assert(process.env.FOO === "foo value", "process.env.FOO not populated");
-		// eslint-disable-next-line turbo/no-undeclared-env-vars
+		// eslint-disable-next-line turbo/no-undeclared-env-vars -- Worker runtime code: populated via Worker bindings, not a Node.js process env var
 		assert(process.env.BAR === "bar secret", "process.env.BAR not populated");
 
 		const processEnvKeys = Object.keys(process.env).sort();

packages/vite-plugin-cloudflare/playground/node-env/src/index.ts

@@ -9,7 +9,7 @@ export default {
 				React.createElement(
 					"p",
 					null,
-					// eslint-disable-next-line turbo/no-undeclared-env-vars
+					// eslint-disable-next-line turbo/no-undeclared-env-vars -- Worker runtime code: build-time replaced by Vite, not a Node.js process env var
 					`The value of process.env.NODE_ENV is "${process.env.NODE_ENV}"`
 				),
 			])

packages/vite-plugin-cloudflare/playground/partyserver/src/main.tsx

@@ -2,9 +2,11 @@ import { StrictMode } from "react";
 import { createRoot } from "react-dom/client";
 import App from "./App.tsx";
 
-// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
-createRoot(document.getElementById("root")!).render(
-	<StrictMode>
-		<App />
-	</StrictMode>
-);
+const rootElement = document.getElementById("root");
+if (rootElement) {
+	createRoot(rootElement).render(
+		<StrictMode>
+			<App />
+		</StrictMode>
+	);
+}