remove skipLastDeployedFromApiCheck from deploy helpers (#14399)

Author: emily-shen

.changeset/good-hoops-joke.md

@@ -0,0 +1,7 @@
+---
+"@cloudflare/deploy-helpers": patch
+---
+
+remove skipLastDeployedFromApiCheck
+
+This was a temporary option to bypass an API issue, which has been fixed API side.

packages/deploy-helpers/src/deploy/helpers/validate-worker-props.ts

@@ -242,10 +242,7 @@ export async function preUploadApiChecks(
 						return { workerTag, tags, workerExists, aborted: true };
 					}
 				}
-			} else if (
-				script.last_deployed_from === "api" &&
-				!props.skipLastDeployedFromApiCheck
-			) {
+			} else if (script.last_deployed_from === "api") {
 				logger.warn(
 					`You are about to upload a Worker that was last updated via the script API.\nEdits that have been made via the script API will be overridden by your local code and config.`
 				);

packages/deploy-helpers/src/shared/types.ts

@@ -108,8 +108,6 @@ export type SharedDeployVersionsProps = {
 	resourcesProvision: boolean;
 	/** Controls whether provisioned resource IDs are written back to the config file. */
 	skipProvisioningConfigWriteback: boolean;
-	/** temporary hack - cf is not yet a recognised deploy source, so any deploys from cf comes back normalised to 'api'*/
-	skipLastDeployedFromApiCheck: boolean;
 	/** From --strict arg. In strict mode, conflicting pre-upload checks abort instead of auto-continuing. */
 	strict: boolean;
 };

packages/wrangler/src/deployment-bundle/merge-config-args.ts

@@ -96,7 +96,6 @@ async function mergeSharedConfigArgs(
 		sendMetrics,
 		resourcesProvision: getFlag("RESOURCES_PROVISION") ?? false,
 		skipProvisioningConfigWriteback: false,
-		skipLastDeployedFromApiCheck: false,
 		strict: args.strict ?? false,
 	};