[wrangler] fix: suppress status badge when printBanner returns false (#13837)

Author: matingathani

.changeset/fix-beta-banner-respects-print-banner.md

@@ -0,0 +1,5 @@
+---
+"wrangler": patch
+---
+
+Fix beta/open-beta status message ignoring `printBanner: false` — when a command sets `printBanner: (args) => !args.json`, the status banner no longer appears in JSON output

packages/wrangler/src/__tests__/ai-search.test.ts

@@ -236,6 +236,16 @@ describe("ai-search commands", () => {
 			expect(parsed).toEqual([MOCK_INSTANCE]);
 		});
 
+		it("should not print beta status banner when --json is passed", async ({
+			expect,
+		}) => {
+			mockListInstances([MOCK_INSTANCE]);
+			await runWrangler("ai-search list --json");
+			// The beta/open-beta statusMessage must not appear in stderr when
+			// printBanner returns false (i.e. when --json suppresses the banner).
+			expect(std.warn).not.toContain("open beta");
+		});
+
 		it("should output empty JSON array when no instances exist with --json", async ({
 			expect,
 		}) => {

packages/wrangler/src/core/register-yargs-command.ts

@@ -127,21 +127,29 @@ function createHandler(def: InternalCommandDefinition, argv: string[]) {
 
 		try {
 			const shouldPrintBanner = def.behaviour?.printBanner ?? true;
-
-			if (
+			const bannerEnabled =
 				shouldPrintBanner === true ||
 				(typeof shouldPrintBanner === "function" &&
-					shouldPrintBanner(args) === true)
-			) {
+					shouldPrintBanner(args) === true);
+
+			if (bannerEnabled) {
 				await printWranglerBanner();
 			}
 
+			// Suppress statusMessage when printBanner is a dynamic function that
+			// returned false (e.g. `--json` mode). When printBanner is the static
+			// boolean `false`, we preserve existing behaviour and still show
+			// status warnings — those commands opted out of the Wrangler banner,
+			// not necessarily the status message.
+			const statusMessageEnabled =
+				typeof shouldPrintBanner !== "function" || bannerEnabled;
+
 			if (!getWranglerHideBanner()) {
 				if (def.metadata.deprecated) {
 					logger.warn(def.metadata.deprecatedMessage);
 				}
 
-				if (def.metadata.statusMessage) {
+				if (statusMessageEnabled && def.metadata.statusMessage) {
 					logger.warn(def.metadata.statusMessage);
 				}
 			}