Update workflow terminate rollback typing

Author: vaishnav-mk

packages/miniflare/scripts/openapi-filter-config.ts

@@ -1172,7 +1172,7 @@ const config = {
 										rollback: {
 											type: "boolean",
 											description:
-												"Run rollback before terminating. Only valid when action is terminate.",
+												"The option to trigger rollbacks when terminating the workflow instance.",
 										},
 									},
 								},

packages/miniflare/src/workers/local-explorer/generated/types.gen.ts

@@ -1748,7 +1748,7 @@ export type WorkflowsChangeInstanceStatusData = {
 			type?: "do" | "sleep" | "waitForEvent";
 		};
 		/**
-		 * Run rollback before terminating. Only valid when action is terminate.
+		 * The option to trigger rollbacks when terminating the workflow instance.
 		 */
 		rollback?: boolean;
 	};

packages/miniflare/src/workers/local-explorer/openapi.local.json

@@ -1813,7 +1813,7 @@
 									},
 									"rollback": {
 										"type": "boolean",
-										"description": "Run rollback before terminating. Only valid when action is terminate."
+										"description": "The option to trigger rollbacks when terminating the workflow instance."
 									}
 								}
 							}

packages/miniflare/src/workers/workflows/wrapped-binding.worker.ts

@@ -1,6 +1,5 @@
 import type {
 	WorkflowBinding,
-	WorkflowHandle,
 	WorkflowInstanceRestartOptions,
 	WorkflowInstanceTerminateOptions,
 } from "@cloudflare/workflows-shared/src/binding";
@@ -73,8 +72,7 @@ class InstanceImpl implements WorkflowInstance {
 	) {}
 
 	private async getInstance(): Promise<WorkflowInstance & Disposable> {
-		return (await this.binding.get(this.id)) as unknown as WorkflowInstance &
-			Disposable;
+		return (await this.binding.get(this.id)) as WorkflowInstance & Disposable;
 	}
 
 	public async pause(): Promise<void> {
@@ -92,7 +90,11 @@ class InstanceImpl implements WorkflowInstance {
 	): Promise<void> {
 		using instance = await this.getInstance();
 		// TODO(vaish): remove cast once @cloudflare/workers-types ships terminate options
-		await (instance as unknown as WorkflowHandle).terminate(options);
+		await (
+			instance.terminate as (
+				options?: WorkflowInstanceTerminateOptions
+			) => Promise<void>
+		)(options);
 	}
 
 	public async restart(

packages/workflows-shared/src/binding.ts

@@ -99,7 +99,7 @@ export class WorkflowBinding extends WorkerEntrypoint<Env> {
 		};
 	}
 
-	public async get(id: string): Promise<WorkflowHandle> {
+	public async get(id: string): Promise<WorkflowInstance> {
 		const stubId = this.env.ENGINE.idFromName(id);
 		const stub = this.env.ENGINE.get(stubId);