[wrangler] Include column names in D1 SQL export by penalosa · Pull Request #12277 · cloudflare/workers-sdk

penalosa · 2026-01-29T15:30:51Z

D1 SQL exports now include column names in INSERT statements. Previously, exports generated:

INSERT INTO "users" VALUES(1,'John','john@example.com');

Now exports generate:

INSERT INTO "users" ("id","name","email") VALUES(1,'John','john@example.com');

This ensures that exported SQL can be successfully imported even when the target table has columns in a different order than the original, which commonly occurs during iterative development when schemas evolve.

Tests
- Tests included/updated
- Automated tests not possible - manual testing has been completed as follows:
- Additional testing not necessary because:
Public documentation
- Cloudflare docs PR(s):
- Documentation not necessary because: This is a bug fix with no user-facing API changes

changeset-bot · 2026-01-29T15:30:57Z

🦋 Changeset detected

Latest commit: a2be02c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
wrangler	Patch
@cloudflare/vite-plugin	Patch
@cloudflare/vitest-pool-workers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

claude · 2026-01-29T15:31:16Z

Claude finished @penalosa's task —— View job

Changeset Review

Todo List

Read changeset guidelines
Read changeset file
Validate changeset against criteria
Post review results

✅ All changesets look good

The changeset at .changeset/include-column-names-d1-export.md passes validation:

Version Type: ✅ patch - Appropriate for a bug fix that improves SQL export behavior
Changelog Quality: ✅ Clear title and detailed body explaining the change and its benefit
Markdown Headers: ✅ No h1/h2/h3 headers used
Analytics: ✅ No analytics changes in this PR
Experimental Features: ✅ Not applicable - this is a fix to stable functionality

pkg-pr-new · 2026-01-29T15:35:03Z

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12277

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12277

miniflare

npm i https://pkg.pr.new/miniflare@12277

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12277

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12277

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12277

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12277

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12277

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@12277

wrangler

npm i https://pkg.pr.new/wrangler@12277

commit: a2be02c

penalosa · 2026-01-29T17:53:51Z

@claude this seems to be failing tests. Can you analyse and fix?

claude · 2026-01-29T17:54:07Z

Claude finished @penalosa's task —— View job

✅ Tests Fixed Successfully!

Todo List

Issue Identified and Fixed

The tests were failing because they expected the old INSERT format without column names:

INSERT INTO "foo" VALUES(1,'xxx');

But after your changes to include column names in D1 SQL exports, the code now generates:

INSERT INTO "foo" ("id","value") VALUES(1,'xxx');

Changes Made

Updated test expectations in /packages/wrangler/src/__tests__/d1/export.test.ts:

Fixed INSERT statement expectations for both foo and bar tables
Added column names ("id","value") to all INSERT statements in the test assertions

The fix has been committed and pushed to the PR branch. The tests should now pass with the new column name format.

devin-ai-integration

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional flags.

vicb

LGTM, one nit

alsuren

I think I agree with this. We are diverging from the sqlite .dump command, and making the output more verbose, but it should make things more robust (sqlite column ordering is notoriously fragile).

@penalosa Let's hold off on merging this until we're ready to merge the internal copy of it as well, just in case there is anything we've not thought of (I tagged you in my gitlab MR for this).

dario-piotrowicz

This needs to wait until the internal PR has landed

alsuren · 2026-02-27T11:34:26Z

I just pushed a tweak to make it match what we're planning to ship in our next release (we checked the stats already and don't expect to break any databases that aren't already broken).

workers-devprod · 2026-04-17T12:54:01Z

Codeowners approval required for this PR:

✅ @cloudflare/d1
✅ @cloudflare/wrangler

Show detailed file reviewers

workers-devprod

Codeowners reviews satisfied

github-actions · 2026-04-17T12:54:16Z

✅ All changesets look good

alsuren · 2026-05-21T10:37:36Z

This needs to wait until the internal PR has landed

@dario-piotrowicz this has been out in prod for a few months with no problems.

…T statements The dumpSql function now includes column names in INSERT statements. Updated test expectations to match the new format: - INSERT INTO "table" VALUES(...) → INSERT INTO "table" ("col1","col2") VALUES(...) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Somhairle MacLeòid <penalosa@users.noreply.github.com>

Add stats tracking for INSERT statement sizes to help analyze the impact of including column names in D1 SQL exports. This syncs the miniflare dumpSql.ts with the d1-worker version from GitLab MR 1056.

workers-devprod · 2026-05-21T13:49:20Z

Codeowners approval required for this PR:

✅ @cloudflare/d1
✅ @cloudflare/wrangler

Show detailed file reviewers

…lumn names

PR is unblocked and ready for review

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: Somhairle MacLeòid <penalosa@users.noreply.github.com> Co-authored-by: David Laban <dlaban@cloudflare.com> Co-authored-by: Pete Bacon Darwin <pbacondarwin@cloudflare.com>

workers-devprod added this to workers-sdk Jan 29, 2026

github-project-automation Bot moved this to Untriaged in workers-sdk Jan 29, 2026

penalosa added the product:d1 Relating to Cloudflare D1: https://developers.cloudflare.com/d1/ label Jan 29, 2026

penalosa marked this pull request as ready for review January 29, 2026 18:28

penalosa requested review from a team as code owners January 29, 2026 18:28

devin-ai-integration Bot reviewed Jan 29, 2026

View reviewed changes

vicb reviewed Jan 29, 2026

View reviewed changes

Comment thread packages/miniflare/src/workers/d1/dumpSql.ts

vicb approved these changes Jan 29, 2026

View reviewed changes

github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Jan 29, 2026

alsuren approved these changes Feb 2, 2026

View reviewed changes

dario-piotrowicz previously requested changes Feb 2, 2026

View reviewed changes

github-project-automation Bot moved this from Approved to In Review in workers-sdk Feb 2, 2026

petebacondarwin marked this pull request as draft February 2, 2026 21:09

petebacondarwin added blocked Blocked on other work internal Requires support from the Cloudflare Platform labels Feb 2, 2026

alsuren force-pushed the fix/7507-d1-export-column-names branch from 1d145a7 to 609e2fc Compare February 27, 2026 11:38

penalosa force-pushed the fix/7507-d1-export-column-names branch from 609e2fc to dd50c1f Compare April 17, 2026 12:53

penalosa marked this pull request as ready for review April 17, 2026 12:53

penalosa requested a review from workers-devprod as a code owner April 17, 2026 12:53

workers-devprod approved these changes Apr 17, 2026

View reviewed changes

This comment was marked as resolved.

Sign in to view

alsuren requested a review from dario-piotrowicz May 21, 2026 10:37

penalosa and others added 3 commits May 21, 2026 14:31

fix(wrangler): include column names in D1 SQL export INSERT statements

b225bb5

fix(miniflare): add DumpSqlStats interface and INSERT size tracking

51c853c

Add stats tracking for INSERT statement sizes to help analyze the impact of including column names in D1 SQL exports. This syncs the miniflare dumpSql.ts with the d1-worker version from GitLab MR 1056.

petebacondarwin force-pushed the fix/7507-d1-export-column-names branch from dd50c1f to 51c853c Compare May 21, 2026 13:48

petebacondarwin removed blocked Blocked on other work internal Requires support from the Cloudflare Platform labels May 21, 2026

petebacondarwin approved these changes May 21, 2026

View reviewed changes

fix(wrangler): update multiple tables test expectations to include co…

a2be02c

…lumn names

petebacondarwin force-pushed the fix/7507-d1-export-column-names branch from af61e9b to a2be02c Compare May 21, 2026 14:22

petebacondarwin enabled auto-merge (squash) May 21, 2026 14:36

petebacondarwin merged commit 8c569c6 into main May 21, 2026
54 checks passed

petebacondarwin deleted the fix/7507-d1-export-column-names branch May 21, 2026 14:37

github-project-automation Bot moved this from In Review to Done in workers-sdk May 21, 2026

workers-devprod mentioned this pull request May 21, 2026

Version Packages #13995

Merged

Conversation

penalosa commented Jan 29, 2026 • edited by devin-ai-integration Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

claude Bot commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changeset Review

Todo List

Uh oh!

pkg-pr-new Bot commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

penalosa commented Jan 29, 2026

Uh oh!

claude Bot commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Tests Fixed Successfully!

Todo List

Issue Identified and Fixed

Changes Made

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

✅ Devin Review: No Issues Found

Uh oh!

Uh oh!

vicb left a comment

Choose a reason for hiding this comment

Uh oh!

alsuren left a comment

Choose a reason for hiding this comment

Uh oh!

dario-piotrowicz left a comment

Choose a reason for hiding this comment

Uh oh!

alsuren commented Feb 27, 2026

Uh oh!

workers-devprod commented Apr 17, 2026

Uh oh!

workers-devprod left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

alsuren commented May 21, 2026

Uh oh!

workers-devprod commented May 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

penalosa commented Jan 29, 2026 •

edited by devin-ai-integration Bot

Loading

changeset-bot Bot commented Jan 29, 2026 •

edited

Loading

claude Bot commented Jan 29, 2026 •

edited

Loading

pkg-pr-new Bot commented Jan 29, 2026 •

edited

Loading

claude Bot commented Jan 29, 2026 •

edited

Loading

github-actions Bot commented Apr 17, 2026 •

edited

Loading