Skip to content

Adds option to skip container rollout on deploy#12656

Merged
petebacondarwin merged 3 commits into
mainfrom
nomitch/container-rollout-none
May 15, 2026
Merged

Adds option to skip container rollout on deploy#12656
petebacondarwin merged 3 commits into
mainfrom
nomitch/container-rollout-none

Conversation

@mikenomitch
Copy link
Copy Markdown
Contributor

@mikenomitch mikenomitch commented Feb 24, 2026

This allows you to skip deploying a container. This is useful if you know that your container is not going to be updated or you don't have Docker locally, but still want to make changes to your Worker.

image
Open with Devin

@mikenomitch mikenomitch requested review from a team as code owners February 24, 2026 00:21
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 24, 2026

🦋 Changeset detected

Latest commit: 04a1e59

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@cloudflare/containers-shared Minor
wrangler Minor
@cloudflare/vite-plugin Major
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

devin-ai-integration[bot]

This comment was marked as resolved.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Feb 24, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12656

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12656

miniflare

npm i https://pkg.pr.new/miniflare@12656

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12656

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12656

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12656

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12656

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12656

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@12656

wrangler

npm i https://pkg.pr.new/wrangler@12656

commit: 04a1e59

devin-ai-integration[bot]

This comment was marked as resolved.

Copy link
Copy Markdown
Contributor

@emily-shen emily-shen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about --containers-rollout=skip

generally lgtm just the test and devin comment

Comment thread packages/wrangler/src/__tests__/containers/deploy.test.ts Outdated
@petebacondarwin
Copy link
Copy Markdown
Contributor

@mikenomitch and @emily-shen - this PR is pretty stale. Is it still desired? If not can we close or convert it to draft?

@emily-shen emily-shen force-pushed the nomitch/container-rollout-none branch from 8e633b3 to d3f3d94 Compare April 20, 2026 12:47
@workers-devprod
Copy link
Copy Markdown
Contributor

workers-devprod commented Apr 20, 2026

Codeowners approval required for this PR:

  • ✅ @cloudflare/cloudchamber
  • ✅ @cloudflare/wrangler
Show detailed file reviewers

devin-ai-integration[bot]

This comment was marked as resolved.

Copy link
Copy Markdown
Contributor

@workers-devprod workers-devprod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@penalosa
Copy link
Copy Markdown
Contributor

penalosa commented May 7, 2026

/bonk resolve the conflicts on this PR

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented May 7, 2026

To https://github.com/cloudflare/workers-sdk.git
! [rejected] nomitch/container-rollout-none -> nomitch/container-rollout-none (non-fast-forward)
error: failed to push some refs to 'https://github.com/cloudflare/workers-sdk.git'
hint: Updates were rejected because the tip of your current branch is behind
hint: its remote counterpart. If you want to integrate the remote changes,
hint: use 'git pull' before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

github run

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented May 7, 2026

@penalosa Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

@petebacondarwin petebacondarwin force-pushed the nomitch/container-rollout-none branch from d02d25f to 04a1e59 Compare May 15, 2026 15:00
@workers-devprod
Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/cloudchamber
  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@github-actions
Copy link
Copy Markdown
Contributor

✅ All changesets look good

@petebacondarwin petebacondarwin merged commit ae047ee into main May 15, 2026
53 checks passed
@petebacondarwin petebacondarwin deleted the nomitch/container-rollout-none branch May 15, 2026 17:55
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changeset-required Skip PR check for valid changeset

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants